Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead #197

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Aug 5, 2021

Backport of JDK-7179006. CPrinterJob.m parts don't apply cleanly because JNF removal is already backported. Included tests have passed on M1 with Rosetta (x86_64 build).

Note that the manual test from JDK-8211055 "TestSaveFileWithoutPrinter.java" does no longer pass with this change. Let's break it for parity with 11.0.13-oracle :-)
(That one seems to be unsupported even with JDK17.)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/197/head:pull/197
$ git checkout pull/197

Update a local copy of the PR:
$ git checkout pull/197
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/197/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 197

View PR using the GUI difftool:
$ git pr show -t 197

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/197.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ea7c47c1bb51d079aff44b88f94b3fe5c76fbce5 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 5, 2021
@TheRealMDoerr TheRealMDoerr marked this pull request as ready for review Aug 5, 2021
@openjdk openjdk bot added the rfr label Aug 5, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2021

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Changes look good to me. The issue with TestSaveFileWithoutPrinter seems to have been reported with JDK-8272469 and there's no fix yet for it, even in head. So I think this one is good to go.

@openjdk
Copy link

openjdk bot commented Aug 27, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 98 new commits pushed to the master branch:

  • 63fc945: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC
  • 9719270: 8248666: AArch64: Use THREAD_LOCAL instead of __thread
  • c816276: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration
  • 910e24b: 8212718: Refactor some annotation processor tests to better use collections
  • 5792854: 8212695: Add explicit timeout to several HTTP Client tests
  • e5ec679: 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up
  • 7100a65: 8169246: java/net/DatagramSocket/ReportSocketClosed.java fails intermittently with BindException
  • 069b4cc: 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"
  • 45ed9e8: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod
  • 7c872ed: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • ... and 88 more: https://git.openjdk.java.net/jdk11u-dev/compare/1223b5830f4a3e58243af79b888575c12a004462...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 27, 2021
@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Sep 2, 2021

Thanks for the review and the approval!
/integrate

@openjdk
Copy link

openjdk bot commented Sep 2, 2021

Going to push as commit 9a5ba0b.
Since your change was applied there have been 100 commits pushed to the master branch:

  • d41b37f: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
  • 0ea1e0f: 8272902: Bump update version for OpenJDK: jdk-11.0.14
  • 63fc945: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC
  • 9719270: 8248666: AArch64: Use THREAD_LOCAL instead of __thread
  • c816276: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration
  • 910e24b: 8212718: Refactor some annotation processor tests to better use collections
  • 5792854: 8212695: Add explicit timeout to several HTTP Client tests
  • e5ec679: 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up
  • 7100a65: 8169246: java/net/DatagramSocket/ReportSocketClosed.java fails intermittently with BindException
  • 069b4cc: 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"
  • ... and 90 more: https://git.openjdk.java.net/jdk11u-dev/compare/1223b5830f4a3e58243af79b888575c12a004462...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 2, 2021
@openjdk openjdk bot added the integrated label Sep 2, 2021
@TheRealMDoerr TheRealMDoerr deleted the 7179006_macos_print branch Sep 2, 2021
@openjdk openjdk bot removed ready rfr labels Sep 2, 2021
@openjdk
Copy link

openjdk bot commented Sep 2, 2021

@TheRealMDoerr Pushed as commit 9a5ba0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants