New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead #197
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
Changes look good to me. The issue with TestSaveFileWithoutPrinter seems to have been reported with JDK-8272469 and there's no fix yet for it, even in head. So I think this one is good to go.
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 98 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks for the review and the approval! |
Going to push as commit 9a5ba0b.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 9a5ba0b. |
Backport of JDK-7179006. CPrinterJob.m parts don't apply cleanly because JNF removal is already backported. Included tests have passed on M1 with Rosetta (x86_64 build).
Note that the manual test from JDK-8211055 "TestSaveFileWithoutPrinter.java" does no longer pass with this change. Let's break it for parity with 11.0.13-oracle :-)
(That one seems to be unsupported even with JDK17.)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/197/head:pull/197
$ git checkout pull/197
Update a local copy of the PR:
$ git checkout pull/197
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/197/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 197
View PR using the GUI difftool:
$ git pr show -t 197
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/197.diff