Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout #1983

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 22, 2023

I backport this for parity with 11.0.20-oracle.

Resolve due to context differences.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout (Bug - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1983/head:pull/1983
$ git checkout pull/1983

Update a local copy of the PR:
$ git checkout pull/1983
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1983/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1983

View PR using the GUI difftool:
$ git pr show -t 1983

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1983.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fb300a3ff3b991cd35ddd971ba768a2d22946914 8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 22, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2023

Webrevs

@phohensee
Copy link
Member

/clean

except for copyright.

@openjdk openjdk bot added the clean label Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@phohensee This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 22, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jun 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

Going to push as commit 77837e3.
Since your change was applied there have been 7 commits pushed to the master branch:

  • e30705e: 8247968: test/jdk/javax/crypto/SecretKeyFactory/security.properties has wrong header
  • 30f0493: 8239007: java/math/BigInteger/largeMemory/ tests should be disabled on 32-bit platforms
  • 114bb9a: 8239537: cgroup MetricsTester testMemorySubsystem fails sometimes when testing memory.kmem.tcp.usage_in_bytes
  • 5506f90: 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached"
  • ffe80b2: 8237183: Bug ID missing for test in patch which fixed JDK-8230665
  • 50f876c: 8232101: (sctp) Add minimal sanity tests for SCTP
  • ef1e4fa: 8224729: Cleanups in sun/security/provider/certpath/ldap/LDAPCertStoreImpl.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2023
@openjdk openjdk bot closed this Jun 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@GoeLin Pushed as commit 77837e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8251517 branch February 1, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants