Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249548: backward focus traversal gets stuck in button group #199

Closed
wants to merge 1 commit into from
Closed

8249548: backward focus traversal gets stuck in button group #199

wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Aug 5, 2021

A clean backport for parity with Oracle 11.0.14.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8249548: backward focus traversal gets stuck in button group

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/199/head:pull/199
$ git checkout pull/199

Update a local copy of the PR:
$ git checkout pull/199
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 199

View PR using the GUI difftool:
$ git pr show -t 199

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/199.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 22bb597d0d2d901c5c8227ea700ab27c670dd545 8249548: backward focus traversal gets stuck in button group Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249548: backward focus traversal gets stuck in button group

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 1faefed: 8253424: Add support for running pre-submit testing using GitHub Actions
  • d780f93: 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows
  • 90d30cc: 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings
  • 9d521b1: 8257913: Add more known library locations to simplify Linux cross-compilation
  • 5464d62: 8238930: problem list compiler/c2/Test8004741.java
  • 1c77fa8: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
  • 52a32a7: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2021

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 24, 2021

Going to push as commit 5a539db.
Since your change was applied there have been 75 commits pushed to the master branch:

  • da90fbb: 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter
  • f334c2e: 8263136: C4530 was reported from VS 2019 at access bridge
  • 13ddf0e: 8261072: AArch64: Fix MacroAssembler::get_thread convention
  • 4699467: 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply
  • 4a3afd7: 8248657: Windows: strengthening in ThreadCritical regarding memory model
  • 8afb159: 8250824: AArch64: follow up for JDK-8248414
  • 6a6e00e: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
  • 83d916e: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u
  • 417b388: 8272472: StackGuardPages test doesn't build with glibc 2.34
  • a27ee49: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode
  • ... and 65 more: https://git.openjdk.java.net/jdk11u-dev/compare/1223b5830f4a3e58243af79b888575c12a004462...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2021
@openjdk
Copy link

openjdk bot commented Aug 24, 2021

@zhengyu123 Pushed as commit 5a539db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant