Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284524: Create an automated test for JDK-4422362 #1991

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 22, 2023

I backport this for parity with 11.0.20-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284524: Create an automated test for JDK-4422362 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1991/head:pull/1991
$ git checkout pull/1991

Update a local copy of the PR:
$ git checkout pull/1991
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1991/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1991

View PR using the GUI difftool:
$ git pr show -t 1991

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1991.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b9de0a7556f7be2c6afc6bb41bfa0339b639ff88 8284524: Create an automated test for JDK-4422362 Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284524: Create an automated test for JDK-4422362

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2023

Going to push as commit b6ffc25.
Since your change was applied there have been 28 commits pushed to the master branch:

  • e8c9452: 8284767: Create an automated test for JDK-4422535
  • 79d0185: 8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java
  • dccbde7: 8247895: SHA1PRNGReseed.java is calling setSeed(0)
  • e986452: 8263970: Manual test javax/swing/JTextField/JapaneseReadingAttributes/JapaneseReadingAttributes.java failed
  • 398f413: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases
  • 480b23d: 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp
  • 08e0d08: 8310620: [11u] Problemlist failing aot tests on macos x64
  • 770c1f6: 8293562: KeepAliveCache Blocks Threads while Closing Connections
  • ccbb928: 8260878: com/sun/jdi/JdbOptions.java fails without jfr
  • 193dc76: 8259796: timed CompletableFuture.get may swallow InterruptedException
  • ... and 18 more: https://git.openjdk.org/jdk11u-dev/compare/6e12eba9a9b29635c136984dc24e9d019dc07560...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2023
@openjdk openjdk bot closed this Jun 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2023
@openjdk
Copy link

openjdk bot commented Jun 27, 2023

@GoeLin Pushed as commit b6ffc25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant