Skip to content

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 5, 2021

Hi all,

this pull request contains a backport of JDK-8210819 from the openjdk/jdk repository.

The commit being backported was authored by Frank Yuan on 18 Sep 2018 and was reviewed by Chris Hegarty.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/201/head:pull/201
$ git checkout pull/201

Update a local copy of the PR:
$ git checkout pull/201
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 201

View PR using the GUI difftool:
$ git pr show -t 201

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/201.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@RealCLanger RealCLanger changed the title Real c langer backport c1bbf898 Backport c1bbf898e4a3ce6756d5ffeedd9f1ddd635b2fba Aug 5, 2021
@openjdk openjdk bot changed the title Backport c1bbf898e4a3ce6756d5ffeedd9f1ddd635b2fba 8210819: Update the host name in CNameTest.java Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210819: Update the host name in CNameTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 13, 2021

Going to push as commit de35864.
Since your change was applied there have been 29 commits pushed to the master branch:

  • b157064: 8209772: Refactor shell test java/util/ServiceLoader/basic/basic.sh to java
  • 97930e7: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test
  • b1e6377: 8254850: Update terminology in java.awt.GridBagLayout source code comments
  • b11ac53: 8210406: Refactor java.util.PluggableLocale:i18n shell tests to plain java tests
  • 156c939: 8158066: SourceDebugExtensionTest fails to rename file
  • 50a6d9d: 8210407: Refactor java.util.Calendar:i18n shell tests to plain java tests
  • 51cd685: 8268776: Test ADatagramSocket.java missing /othervm from @run tag
  • 7b6f391: 8242882: opening jar file with large manifest might throw NegativeArraySizeException
  • dffc5f4: 8211092: test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java fails intermittently when cleaning up
  • 236a469: 8214937: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed due to unexpected expiration date
  • ... and 19 more: https://git.openjdk.java.net/jdk11u-dev/compare/1538790fdcad884a40f9a91ddba8587affd034d6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 13, 2021
@openjdk
Copy link

openjdk bot commented Aug 13, 2021

@RealCLanger Pushed as commit de35864.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant