Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit" #2014

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 30, 2023

I backport this for parity with 11.0.21-oracle.

I had to resolve the ProblemList, as the test was not problem listed. (JDK-8232922)
Will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit" (Bug - P4)
  • JDK-8232922: Add java/math/BigInteger/largeMemory/SymmetricRangeTests.java to ProblemList-Xcomp (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2014/head:pull/2014
$ git checkout pull/2014

Update a local copy of the PR:
$ git checkout pull/2014
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2014

View PR using the GUI difftool:
$ git pr show -t 2014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2014.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin
Copy link
Member Author

GoeLin commented Jun 30, 2023

/issue JDK-8232922

@GoeLin
Copy link
Member Author

GoeLin commented Jun 30, 2023

/clean

@openjdk openjdk bot changed the title Backport cfd41c0c1dfae823d465711d147373c343977f00 8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit" Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@GoeLin
Adding additional issue to issue list: 8232922: Add java/math/BigInteger/largeMemory/SymmetricRangeTests.java to ProblemList-Xcomp.

@openjdk openjdk bot added the clean label Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit"
8232922: Add java/math/BigInteger/largeMemory/SymmetricRangeTests.java to ProblemList-Xcomp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 4, 2023

Going to push as commit f321deb.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 8528c52: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts
  • 003bdbb: 8168261: Use server cipher suites preference by default
  • e5d6793: 8304867: Explicitly disable dtrace for ppc builds
  • da6c1c7: 8252530: Fix inconsistencies in hotspot whitebox
  • 9c97b37: 8265980: Fix systemDictionary and loaderConstraints printing
  • 339518e: 8306484: Open source several AWT Choice jtreg tests
  • aa54ef1: 8306682: Open source a few more AWT Choice tests
  • 54cb972: 8298974: Add ftcolor.c to imported freetype sources
  • abfab03: 8228403: SignTwice.java failed with java.io.FileNotFoundException: File name too long

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 4, 2023
@openjdk openjdk bot closed this Jul 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2023
@openjdk
Copy link

openjdk bot commented Jul 4, 2023

@GoeLin Pushed as commit f321deb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant