Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286620: Create regression test for verifying setMargin() of JRadioButton #2015

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 30, 2023

I backport this for parity with 11.0.21-oracle.

I had to replace the """ string.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286620: Create regression test for verifying setMargin() of JRadioButton (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2015/head:pull/2015
$ git checkout pull/2015

Update a local copy of the PR:
$ git checkout pull/2015
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2015

View PR using the GUI difftool:
$ git pr show -t 2015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2015.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 67f1bd7ff1bb218fd6de9ef1e957f729013e133c 8286620: Create regression test for verifying setMargin() of JRadioButton Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 30, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2023

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jul 4, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8286620: Create regression test for verifying setMargin() of JRadioButton

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 842f8ae: 8307301: Update HarfBuzz to 7.2.0
  • c99f1e0: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • c4fb98d: 8307569: Build with gcc8 is broken after JDK-8307301
  • 985c7a1: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"
  • f321deb: 8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit"
  • 8528c52: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts
  • 003bdbb: 8168261: Use server cipher suites preference by default
  • e5d6793: 8304867: Explicitly disable dtrace for ppc builds
  • da6c1c7: 8252530: Fix inconsistencies in hotspot whitebox
  • 9c97b37: 8265980: Fix systemDictionary and loaderConstraints printing
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/142d467c03b5331e73e4f57db403b08d6f71ecd9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 4, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jul 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

Going to push as commit a975a1e.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 842f8ae: 8307301: Update HarfBuzz to 7.2.0
  • c99f1e0: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • c4fb98d: 8307569: Build with gcc8 is broken after JDK-8307301
  • 985c7a1: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"
  • f321deb: 8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit"
  • 8528c52: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts
  • 003bdbb: 8168261: Use server cipher suites preference by default
  • e5d6793: 8304867: Explicitly disable dtrace for ppc builds
  • da6c1c7: 8252530: Fix inconsistencies in hotspot whitebox
  • 9c97b37: 8265980: Fix systemDictionary and loaderConstraints printing
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/142d467c03b5331e73e4f57db403b08d6f71ecd9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2023
@openjdk openjdk bot closed this Jul 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@GoeLin Pushed as commit a975a1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8286620 branch July 5, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants