8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero

[RealLucy]

Fix request [11u]

I backport this for parity with 11.0.21-oracle. The change does not at all apply cleanly.

• ResourceMark not added in classLoaderData.cpp (logging code which would need it is not present).
• Deleted method Klass::replace_java_mirror() did not exist in jdk11.
• class RedefineVerifyMark exists in share/prims/jvmtiThreadState.hpp, not in share/prims/jvmtiRedefineClasses.cpp

SAP nightly tests did not reveal any issue related to this PR.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero (Bug - P2)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2019/head:pull/2019
$ git checkout pull/2019

Update a local copy of the PR:
$ git checkout pull/2019
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2019/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2019

View PR using the GUI difftool:
$ git pr show -t 2019

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2019.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (866447a5)

[TheRealMDoerr]

LGTM. Thanks for backporting!

[openjdk]

@RealLucy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 842f8ae: 8307301: Update HarfBuzz to 7.2.0
• c99f1e0: 8307604: gcc12 based Alpine build broken build after JDK-8307301
• c4fb98d: 8307569: Build with gcc8 is broken after JDK-8307301
• 985c7a1: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"
• f321deb: 8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit"
• 8528c52: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts
• 003bdbb: 8168261: Use server cipher suites preference by default
• e5d6793: 8304867: Explicitly disable dtrace for ppc builds
• da6c1c7: 8252530: Fix inconsistencies in hotspot whitebox

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealLucy]

/integrate

[openjdk]

Going to push as commit 6b77069.
Since your change was applied there have been 11 commits pushed to the master branch:

• b3417d8: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
• a975a1e: 8286620: Create regression test for verifying setMargin() of JRadioButton
• 842f8ae: 8307301: Update HarfBuzz to 7.2.0
• c99f1e0: 8307604: gcc12 based Alpine build broken build after JDK-8307301
• c4fb98d: 8307569: Build with gcc8 is broken after JDK-8307301
• 985c7a1: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"
• f321deb: 8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit"
• 8528c52: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts
• 003bdbb: 8168261: Use server cipher suites preference by default
• e5d6793: 8304867: Explicitly disable dtrace for ppc builds
• ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/9c97b37e1bca898a3ba2832342c909879cb4e31c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealLucy Pushed as commit 6b77069.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.