Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291444: GHA builds/tests won't run manually if disabled from automatic running #2024

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 4, 2023

Hi all,

This pull request contains a backport of JDK-8291444, commit 17744caa from the openjdk/jdk17u-dev repository.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291444: GHA builds/tests won't run manually if disabled from automatic running (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2024/head:pull/2024
$ git checkout pull/2024

Update a local copy of the PR:
$ git checkout pull/2024
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2024/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2024

View PR using the GUI difftool:
$ git pr show -t 2024

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2024.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 17744caa87ac313e924deb92af37c491cf7c97bc 8291444: GHA builds/tests won't run manually if disabled from automatic running Jul 4, 2023
@openjdk
Copy link

openjdk bot commented Jul 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 4, 2023

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8291444: GHA builds/tests won't run manually if disabled from automatic running

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 842f8ae: 8307301: Update HarfBuzz to 7.2.0
  • c99f1e0: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • c4fb98d: 8307569: Build with gcc8 is broken after JDK-8307301

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2023

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

Going to push as commit 532fbe9.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 6b77069: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero
  • b3417d8: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
  • a975a1e: 8286620: Create regression test for verifying setMargin() of JRadioButton
  • 842f8ae: 8307301: Update HarfBuzz to 7.2.0
  • c99f1e0: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • c4fb98d: 8307569: Build with gcc8 is broken after JDK-8307301

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2023
@openjdk openjdk bot closed this Jul 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@RealCLanger Pushed as commit 532fbe9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant