Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3 #2026

Closed
wants to merge 1 commit into from

Conversation

RealLucy
Copy link
Contributor

@RealLucy RealLucy commented Jul 4, 2023

This backport is for parity with 11.0.21-oracle.

Patch did not apply cleanly. There was a whitespace diff which confused the merge algorithm. In addition, change JDK-8207146 is missing Unsafe::compareAndSetReference. It had to be reverted to Unsafe::compareAndSetObject

Manual testing successful - with and without fix.
SAP nightly tests did not reveal any issue related to this PR.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2026/head:pull/2026
$ git checkout pull/2026

Update a local copy of the PR:
$ git checkout pull/2026
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2026/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2026

View PR using the GUI difftool:
$ git pr show -t 2026

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2026.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2023

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ecf8842cd2309210f3d5eee7f9f28a198a860686 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3 Jul 4, 2023
@openjdk
Copy link

openjdk bot commented Jul 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 4, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@RealLucy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 6b77069: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero
  • b3417d8: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
  • a975a1e: 8286620: Create regression test for verifying setMargin() of JRadioButton
  • 842f8ae: 8307301: Update HarfBuzz to 7.2.0
  • c99f1e0: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • c4fb98d: 8307569: Build with gcc8 is broken after JDK-8307301
  • 985c7a1: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"
  • f321deb: 8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit"
  • 8528c52: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts
  • 003bdbb: 8168261: Use server cipher suites preference by default
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/9c97b37e1bca898a3ba2832342c909879cb4e31c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 5, 2023
@RealLucy
Copy link
Contributor Author

RealLucy commented Jul 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

Going to push as commit dbf8820.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 750387b: 8297887: Update Siphash
  • 2854320: 8306638: Open source some AWT tests related to datatransfer and Toolkit
  • 9fecfb3: 8305950: Have -XshowSettings option display tzdata version
  • 6b84480: 8304054: Linux: NullPointerException from FontConfiguration.getVersion in case no fonts are installed
  • 532fbe9: 8291444: GHA builds/tests won't run manually if disabled from automatic running
  • 6b77069: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero
  • b3417d8: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
  • a975a1e: 8286620: Create regression test for verifying setMargin() of JRadioButton
  • 842f8ae: 8307301: Update HarfBuzz to 7.2.0
  • c99f1e0: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/9c97b37e1bca898a3ba2832342c909879cb4e31c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2023
@openjdk openjdk bot closed this Jul 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@RealLucy Pushed as commit dbf8820.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants