Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272078: Wrong Checksums in Temurin BootJDK dependencies #203

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 6, 2021

Update checksums for Temurin 11.0.12+7 binaries


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272078: Wrong Checksums in Temurin BootJDK dependencies

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/203/head:pull/203
$ git checkout pull/203

Update a local copy of the PR:
$ git checkout pull/203
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 203

View PR using the GUI difftool:
$ git pr show -t 203

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/203.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 6, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8272078 8272078: Wrong Checksums in Temurin BootJDK dependencies Aug 6, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 6, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 6, 2021

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, thanks! I verified the checksums by hand as well.

@openjdk
Copy link

openjdk bot commented Aug 6, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272078: Wrong Checksums in Temurin BootJDK dependencies

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3d12a46: 8234510: Remove file seeking requirement for writing a heap dump

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 6, 2021
@shipilev
Copy link
Member

shipilev commented Aug 6, 2021

@jerboaa, please approve this push to unbreak GHA :)

@jerboaa
Copy link
Contributor

jerboaa commented Aug 6, 2021

@jerboaa, please approve this push to unbreak GHA :)

Done :)

@RealCLanger
Copy link
Contributor Author

@jerboaa, please approve this push to unbreak GHA :)

Done :)

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 6, 2021

Going to push as commit 1538790.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 3d12a46: 8234510: Remove file seeking requirement for writing a heap dump

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 6, 2021
@openjdk
Copy link

openjdk bot commented Aug 6, 2021

@RealCLanger Pushed as commit 1538790.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the test-gha branch August 6, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants