8307572: AArch64: Vector registers are clobbered by some macroassemblers

[nsjian]

jdk11 also has the bug of JDK-8307572, so I propose to backport the fix to jdk11u. This is not a clean backport. Main changes:

1. Definition of reg_class v4_reg..v7_reg, and operand vRegD_V4..vRegD_V7 are missing in jdk11u aarch64.ad, which was introduced in JDK-8214527. Added those definitions in this patch, as we need to claim them to be killed in match rules.

2. JDK-8274243 (not a valid backport for 11u) changed MacroAssembler::encode_iso_array() a lot, but the bug of invalid use of v4/v5 still exists before and after that patch. Fixed the conflicts by using jdk11u naming convention.

No new jtreg test failure with both release and fastdebug build. Test case added in JDK-8307572 passes now, which fails without the backport.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307572: AArch64: Vector registers are clobbered by some macroassemblers (Bug - P2)

Reviewers

• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2032/head:pull/2032
$ git checkout pull/2032

Update a local copy of the PR:
$ git checkout pull/2032
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2032/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2032

View PR using the GUI difftool:
$ git pr show -t 2032

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2032.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back njian! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (575dfffe)
• 00: Full (9940bbd6)

[openjdk]

@nsjian This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307572: AArch64: Vector registers are clobbered by some macroassemblers

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 161a941: 8225012: sanity/client/SwingSet/src/ToolTipDemoTest.java fails on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[nsjian]

Thank you @theRealAph for the review!

All checks are clean with jdk11u-fix-yes approval in JBS. Can someone please help to sponsor? Thanks!

/integrate

[openjdk]

@nsjian
Your change (at version 575dfff) is now ready to be sponsored by a Committer.

[theRealAph]

/sponsor

[openjdk]

Going to push as commit 32e16ae.
Since your change was applied there has been 1 commit pushed to the master branch:

• 161a941: 8225012: sanity/client/SwingSet/src/ToolTipDemoTest.java fails on Windows

Your commit was automatically rebased without conflicts.

[openjdk]

@theRealAph @nsjian Pushed as commit 32e16ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.