Skip to content

Conversation

@luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jul 11, 2023

I backport this for parity with 11.0.21-oracle.
test/jdk/sun/security/tools/jarsigner/warnings/NoTimestampTest.java
Resolved due to context
test/jdk/sun/security/tools/jarsigner/warnings/Test.java
Copyright


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8220410: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed with missing expected output (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2036/head:pull/2036
$ git checkout pull/2036

Update a local copy of the PR:
$ git checkout pull/2036
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2036/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2036

View PR using the GUI difftool:
$ git pr show -t 2036

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2036.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2023

👋 Welcome back luchenlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3c34b7a2616922dddaf67d5f9e5907f260d302c8 8220410: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed with missing expected output Jul 11, 2023
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 11, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2023

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is NoTimestampTest where the Copyright has been omitted because it is already 2019.
I don't see any differences in context, though. The copyright seems the only difference to the original change.
LGTM

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8220410: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed with missing expected output

Using the same timezone for jar verifying and date formatting

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 32e16ae: 8307572: AArch64: Vector registers are clobbered by some macroassemblers
  • 161a941: 8225012: sanity/client/SwingSet/src/ToolTipDemoTest.java fails on Windows
  • 8e971f5: 8305421: Work around JDK-8305420 in CDSJDITest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 13, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 14, 2023
@openjdk
Copy link

openjdk bot commented Jul 14, 2023

@luchenlin
Your change (at version 9893044) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Jul 17, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 17, 2023

Going to push as commit 65e7759.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 32e16ae: 8307572: AArch64: Vector registers are clobbered by some macroassemblers
  • 161a941: 8225012: sanity/client/SwingSet/src/ToolTipDemoTest.java fails on Windows
  • 8e971f5: 8305421: Work around JDK-8305420 in CDSJDITest.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2023
@openjdk openjdk bot closed this Jul 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 17, 2023
@openjdk
Copy link

openjdk bot commented Jul 17, 2023

@GoeLin @luchenlin Pushed as commit 65e7759.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants