Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8230841: Remove oopDesc::equals() #204

Closed
wants to merge 1 commit into from
Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Aug 6, 2021

This is the second patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next.

The equals APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/204/head:pull/204
$ git checkout pull/204

Update a local copy of the PR:
$ git checkout pull/204
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 204

View PR using the GUI difftool:
$ git pr show -t 204

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/204.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 6, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2d6874b861270ea67322d5976a30202bdb6adb1c 8230841: Remove oopDesc::equals() Aug 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Aug 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 6, 2021

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 10, 2021

Paging @rkennke to sanity check this.

Copy link
Contributor

@rkennke rkennke left a comment

LGTM. One small comment, I leave this up to you. Thanks!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 14, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8230841: Remove oopDesc::equals()

Reviewed-by: rkennke, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • b9c24c3: 8210802: temp files left by tests in jdk/java/net/httpclient
  • de35864: 8210819: Update the host name in CNameTest.java
  • b157064: 8209772: Refactor shell test java/util/ServiceLoader/basic/basic.sh to java
  • 97930e7: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test
  • b1e6377: 8254850: Update terminology in java.awt.GridBagLayout source code comments
  • b11ac53: 8210406: Refactor java.util.PluggableLocale:i18n shell tests to plain java tests
  • 156c939: 8158066: SourceDebugExtensionTest fails to rename file
  • 50a6d9d: 8210407: Refactor java.util.Calendar:i18n shell tests to plain java tests
  • 51cd685: 8268776: Test ADatagramSocket.java missing /othervm from @run tag
  • 7b6f391: 8242882: opening jar file with large manifest might throw NegativeArraySizeException
  • ... and 21 more: https://git.openjdk.java.net/jdk11u-dev/compare/1538790fdcad884a40f9a91ddba8587affd034d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 14, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 15, 2021

Got the push approval.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 15, 2021

Going to push as commit 12312a3.
Since your change was applied there have been 36 commits pushed to the master branch:

  • 8a470e1: 8209768: Refactor java/util/prefs/CheckUserPrefsStorage.sh to plain java test
  • 8738bb5: 8213409: Refactor sun.text.IntHashtable:i18n shell tests to plain java tests
  • 2c3f99d: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
  • 80972c5: 8214520: [TEST_BUG] sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java failed with incorrect jtreg tags order
  • ac8510b: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java
  • b9c24c3: 8210802: temp files left by tests in jdk/java/net/httpclient
  • de35864: 8210819: Update the host name in CNameTest.java
  • b157064: 8209772: Refactor shell test java/util/ServiceLoader/basic/basic.sh to java
  • 97930e7: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test
  • b1e6377: 8254850: Update terminology in java.awt.GridBagLayout source code comments
  • ... and 26 more: https://git.openjdk.java.net/jdk11u-dev/compare/1538790fdcad884a40f9a91ddba8587affd034d6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 15, 2021

@shipilev Pushed as commit 12312a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8230841 branch Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants