8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"

[kurashige23]

Hi,

This is a backport of JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"

ChildAlwaysOnTopTest.java is not excluded by ProblemList in 11u. But I detected the test failed on Windows Server 2016.

Also original patch does not apply cleanly to 11u, because the fix uses "StringBuffer.isEmpty()" published in JDK15. I fixed the test so as not to use "StringBuffer.isEmpty()".

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop" (Bug - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2040/head:pull/2040
$ git checkout pull/2040

Update a local copy of the PR:
$ git checkout pull/2040
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2040/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2040

View PR using the GUI difftool:
$ git pr show -t 2040

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2040.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (276eea60)
• 01: Full - Incremental (ced9c2f3)
• 00: Full (2cedd881)

[phohensee]

Copyright date s/b 2022, not 2023. Otherwise good.

[kurashige23]

@phohensee Thanks. I fixed it.

[phohensee]

Looks good now. Thanks for doing the backport.

[openjdk]

⚠️ @kurashige23 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout AlwaysOnTop_8222323
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 581b34f: 8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java
• 35ec241: 8228341: SignTwice.java fails intermittently on Windows
• 9774653: Merge
• a829804: 8311465: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.20
• d61a4b4: 8308682: Enhance AES performance
• 18939b7: 8305312: Enhanced path handling
• 5ba2464: 8304468: Better array usages
• e3b68c5: 8303376: Better launching of JDI
• bc9d129: 8302483: Enhance ZIP performance
• bf301e2: 8302475: Enhance HTTP client file downloading
• ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/32e16aefa99f3688b1c3c100613c699e678c4c1b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[phohensee]

Tagged the JBS issue.

[kurashige23]

@phohensee Thanks for the tagging.

[phohensee]

Approved, please add /integrate.

[kurashige23]

/integrate

[openjdk]

@kurashige23
Your change (at version 276eea6) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 864baf7.
Since your change was applied there have been 17 commits pushed to the master branch:

• c06d748: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out
• 581b34f: 8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java
• 35ec241: 8228341: SignTwice.java fails intermittently on Windows
• 9774653: Merge
• a829804: 8311465: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.20
• d61a4b4: 8308682: Enhance AES performance
• 18939b7: 8305312: Enhanced path handling
• 5ba2464: 8304468: Better array usages
• e3b68c5: 8303376: Better launching of JDI
• bc9d129: 8302483: Enhance ZIP performance
• ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/32e16aefa99f3688b1c3c100613c699e678c4c1b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @kurashige23 Pushed as commit 864baf7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.