8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance

[dhanalla]

Backport of openjdk/jdk#13430

Issue:
JDK-8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2041/head:pull/2041
$ git checkout pull/2041

Update a local copy of the PR:
$ git checkout pull/2041
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2041

View PR using the GUI difftool:
$ git pr show -t 2041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2041.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (bf329aa3)

[RealCLanger]

@dhanalla, please chage the title to "Backport 749d4801937ac145f945765f0ba0980bbccf384f" - then the bots should pick it up correctly.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@dhanalla This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 7cf5b10: 8307128: Open source some drag and drop tests 4
• 894613f: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
• 6e8a66a: 8270331: [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java
• 514c0eb: 8313159: [11u] Fix test SSLEngineKeyLimit.java after Merge error
• 910f35e: 6176679: Application freezes when copying an animated gif image to the system clipboard
• c029177: 8229481: sun/net/www/protocol/https/ChunkedOutputStream.java failed with a SSLException
• e10b887: 8286481: Exception printed to stdout on Windows when storing transparent image in clipboard
• b49e8b2: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
• 7051296: 8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently
• 6747c78: 8297923: java.awt.ScrollPane broken after multiple scroll up/down
• ... and 20 more: https://git.openjdk.org/jdk11u-dev/compare/32e16aefa99f3688b1c3c100613c699e678c4c1b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dhanalla]

Thanks @RealCLanger for reviewing this PR.
Now the PR is clean, I will add 11u backport request on the bug.

[dhanalla]

/integrate

[openjdk]

@dhanalla
Your change (at version bf329aa) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit adc7477.
Since your change was applied there have been 30 commits pushed to the master branch:

• 7cf5b10: 8307128: Open source some drag and drop tests 4
• 894613f: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
• 6e8a66a: 8270331: [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java
• 514c0eb: 8313159: [11u] Fix test SSLEngineKeyLimit.java after Merge error
• 910f35e: 6176679: Application freezes when copying an animated gif image to the system clipboard
• c029177: 8229481: sun/net/www/protocol/https/ChunkedOutputStream.java failed with a SSLException
• e10b887: 8286481: Exception printed to stdout on Windows when storing transparent image in clipboard
• b49e8b2: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
• 7051296: 8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently
• 6747c78: 8297923: java.awt.ScrollPane broken after multiple scroll up/down
• ... and 20 more: https://git.openjdk.org/jdk11u-dev/compare/32e16aefa99f3688b1c3c100613c699e678c4c1b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @dhanalla Pushed as commit adc7477.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.