Skip to content

8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently#2051

Closed
RealLucy wants to merge 2 commits intoopenjdk:masterfrom
RealLucy:JDK-8257993
Closed

8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently#2051
RealLucy wants to merge 2 commits intoopenjdk:masterfrom
RealLucy:JDK-8257993

Conversation

@RealLucy
Copy link
Contributor

@RealLucy RealLucy commented Jul 20, 2023 •
edited by openjdk bot
Loading

This backport is for parity with 11.0.21-oracle

Patch (from jdk16) did not apply at all. Basically, it is a fresh implementation, guided by the original fix. Had to introduce new method "Method* get_new_method() const;" in method.hpp. Did not exist in 11.

Local testing successful.
SAP internal nightly build and test did not show any issues.
Reviewed.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2051/head:pull/2051
$ git checkout pull/2051

Update a local copy of the PR:
$ git checkout pull/2051
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2051

View PR using the GUI difftool:
$ git pr show -t 2051

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2051.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2023

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0a3e446ad95b09de2facee7107f7c1206339ee0d 8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 20, 2023 •
edited
Loading

Webrevs

TheRealMDoerr
TheRealMDoerr approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for backporting!

TheRealMDoerr
TheRealMDoerr reviewed Jul 21, 2023
View reviewed changes
src/hotspot/share/interpreter/interpreterRuntime.cpp Outdated
last_frame.get_index_u2_cpcache(bytecode), bytecode,
CHECK);
}

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original change doesn't introduce this empty line. I suggest to remove it before integrating.

Copy link
Contributor Author

@RealLucy RealLucy Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.
Thanks for the review!

@openjdk
Copy link

openjdk bot commented Jul 21, 2023

@RealLucy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 21, 2023
@RealLucy
Copy link
Contributor Author

RealLucy commented Jul 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2023

Going to push as commit 7051296.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 6747c78: 8297923: java.awt.ScrollPane broken after multiple scroll up/down
  • 93419e5: 8295894: Remove SECOM certificate that is expiring in September 2023
  • f0b10f2: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit
  • 864baf7: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • c06d748: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out
  • 581b34f: 8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java
  • 35ec241: 8228341: SignTwice.java fails intermittently on Windows
  • 9774653: Merge
  • a829804: 8311465: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.20
  • d61a4b4: 8308682: Enhance AES performance
  • ... and 8 more: https://git.openjdk.org/jdk11u-dev/compare/f8d6c54babc6af846607b6e8fe826de7e8c387d3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2023
@openjdk openjdk bot closed this Jul 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2023
@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@RealLucy Pushed as commit 7051296.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TheRealMDoerr TheRealMDoerr TheRealMDoerr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RealLucy @TheRealMDoerr