Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6176679: Application freezes when copying an animated gif image to the system clipboard #2055

Closed
wants to merge 1 commit into from

Conversation

RealLucy
Copy link
Contributor

@RealLucy RealLucy commented Jul 21, 2023

Fx request [11u]

This is for parity with 11.0.21-oracle.

Patch applies cleanly except for a copyright year mismatch.

New test succeeds with patch applied.
Build and test successful.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-6176679: Application freezes when copying an animated gif image to the system clipboard (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2055/head:pull/2055
$ git checkout pull/2055

Update a local copy of the PR:
$ git checkout pull/2055
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2055

View PR using the GUI difftool:
$ git pr show -t 2055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2055.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2023

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6c71859ac240c788364169422e726f8f5443bf75 6176679: Application freezes when copying an animated gif image to the system clipboard Jul 21, 2023
@openjdk
Copy link

openjdk bot commented Jul 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 21, 2023
@RealLucy
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Jul 21, 2023
@openjdk
Copy link

openjdk bot commented Jul 21, 2023

@RealLucy This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jul 21, 2023

@RealLucy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

6176679: Application freezes when copying an animated gif image to the system clipboard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • e10b887: 8286481: Exception printed to stdout on Windows when storing transparent image in clipboard
  • b49e8b2: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
  • 7051296: 8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently
  • 6747c78: 8297923: java.awt.ScrollPane broken after multiple scroll up/down
  • 93419e5: 8295894: Remove SECOM certificate that is expiring in September 2023
  • f0b10f2: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit
  • 864baf7: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • c06d748: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out
  • 581b34f: 8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java
  • 35ec241: 8228341: SignTwice.java fails intermittently on Windows
  • ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/f8d6c54babc6af846607b6e8fe826de7e8c387d3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2023

Webrevs

@RealLucy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 26, 2023

Going to push as commit 910f35e.
Since your change was applied there have been 22 commits pushed to the master branch:

  • c029177: 8229481: sun/net/www/protocol/https/ChunkedOutputStream.java failed with a SSLException
  • e10b887: 8286481: Exception printed to stdout on Windows when storing transparent image in clipboard
  • b49e8b2: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
  • 7051296: 8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently
  • 6747c78: 8297923: java.awt.ScrollPane broken after multiple scroll up/down
  • 93419e5: 8295894: Remove SECOM certificate that is expiring in September 2023
  • f0b10f2: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit
  • 864baf7: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • c06d748: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out
  • 581b34f: 8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java
  • ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/f8d6c54babc6af846607b6e8fe826de7e8c387d3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 26, 2023
@openjdk openjdk bot closed this Jul 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 26, 2023
@openjdk
Copy link

openjdk bot commented Jul 26, 2023

@RealLucy Pushed as commit 910f35e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant