Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8210802: temp files left by tests in jdk/java/net/httpclient #206

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 6, 2021

Hi all,

this pull request contains a backport of JDK-8210802 from the openjdk/jdk repository.

The commit being backported was authored by Hamlin Li on 18 Sep 2018 and was reviewed by Chris Hegarty and Christoph Langer.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8210802: temp files left by tests in jdk/java/net/httpclient

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/206/head:pull/206
$ git checkout pull/206

Update a local copy of the PR:
$ git checkout pull/206
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 206

View PR using the GUI difftool:
$ git pr show -t 206

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/206.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 6, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 1adaa503bb2a5e78a358f2578cdb665f8701b0de 8210802: temp files left by tests in jdk/java/net/httpclient Aug 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210802: temp files left by tests in jdk/java/net/httpclient

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 166 new commits pushed to the master branch:

  • 1538790: 8272078: Wrong Checksums in Temurin BootJDK dependencies
  • 3d12a46: 8234510: Remove file seeking requirement for writing a heap dump
  • 1faefed: 8253424: Add support for running pre-submit testing using GitHub Actions
  • d780f93: 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows
  • 90d30cc: 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings
  • 9d521b1: 8257913: Add more known library locations to simplify Linux cross-compilation
  • 5464d62: 8238930: problem list compiler/c2/Test8004741.java
  • 1c77fa8: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
  • 52a32a7: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers
  • 1223b58: 8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12
  • ... and 156 more: https://git.openjdk.java.net/jdk11u-dev/compare/f55ef1e033a769101e383792c3964da275fd4582...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 6, 2021

Webrevs

Loading

tstuefe
tstuefe approved these changes Aug 6, 2021
Copy link
Member

@tstuefe tstuefe left a comment

Seems easy enough. LGTM.

Though, like Alexey, I am curious which tests were affected by this. I am not sure this is even used (it seems only used by com/sun/net/httpserver/SimpleFileServer, which I don't see being used anywhere).

Loading

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Aug 6, 2021

Seems easy enough. LGTM.

Though, like Alexey, I am curious which tests were affected by this. I am not sure this is even used (it seems only used by com/sun/net/httpserver/SimpleFileServer, which I don't see being used anywhere).

Yep, it's simple stupid parity to get the list empty. I'm sure it does no harm 😃

Loading

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Aug 13, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 13, 2021

Going to push as commit b9c24c3.
Since your change was applied there have been 196 commits pushed to the master branch:

  • de35864: 8210819: Update the host name in CNameTest.java
  • b157064: 8209772: Refactor shell test java/util/ServiceLoader/basic/basic.sh to java
  • 97930e7: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test
  • b1e6377: 8254850: Update terminology in java.awt.GridBagLayout source code comments
  • b11ac53: 8210406: Refactor java.util.PluggableLocale:i18n shell tests to plain java tests
  • 156c939: 8158066: SourceDebugExtensionTest fails to rename file
  • 50a6d9d: 8210407: Refactor java.util.Calendar:i18n shell tests to plain java tests
  • 51cd685: 8268776: Test ADatagramSocket.java missing /othervm from @run tag
  • 7b6f391: 8242882: opening jar file with large manifest might throw NegativeArraySizeException
  • dffc5f4: 8211092: test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java fails intermittently when cleaning up
  • ... and 186 more: https://git.openjdk.java.net/jdk11u-dev/compare/f55ef1e033a769101e383792c3964da275fd4582...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 13, 2021

@RealCLanger Pushed as commit b9c24c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants