Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307128: Open source some drag and drop tests 4 #2060

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jul 27, 2023

I backport this for parity with 11.0.21-oracle.
test/jdk/java/awt/dnd/MouseExitGestureTriggerTest.java
add backport for JDK-8307799, Without this fix test will fail.
other backport clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8307128: Open source some drag and drop tests 4 (Bug - P4)
  • JDK-8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg @requires clause (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2060/head:pull/2060
$ git checkout pull/2060

Update a local copy of the PR:
$ git checkout pull/2060
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2060

View PR using the GUI difftool:
$ git pr show -t 2060

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2060.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2023

👋 Welcome back luchenlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 98294242a94c611e2a713c2d520e59dd873ae4a0 8307128: Open source some drag and drop tests 4 Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 27, 2023
@luchenlin
Copy link
Contributor Author

/issue add JDK-8307799

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@luchenlin
Adding additional issue to issue list: 8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg @requires clause.

@mlbridge
Copy link

mlbridge bot commented Jul 27, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport from 17u.

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307128: Open source some drag and drop tests 4
8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg `@requires` clause

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 6e8a66a: 8270331: [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java
  • 514c0eb: 8313159: [11u] Fix test SSLEngineKeyLimit.java after Merge error

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 31, 2023
@openjdk
Copy link

openjdk bot commented Jul 31, 2023

@luchenlin
Your change (at version 307f4e9) is now ready to be sponsored by a Committer.

@MBaesken
Copy link
Member

MBaesken commented Aug 1, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

Going to push as commit 7cf5b10.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 894613f: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
  • 6e8a66a: 8270331: [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java
  • 514c0eb: 8313159: [11u] Fix test SSLEngineKeyLimit.java after Merge error

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 1, 2023
@openjdk openjdk bot closed this Aug 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@MBaesken @luchenlin Pushed as commit 7cf5b10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants