Skip to content

Conversation

@Korov
Copy link

@Korov Korov commented Jul 27, 2023

fix JDK-8305733


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305733: Pattern.CASE_INSENSITIVE does not take effect in jdk11 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2061/head:pull/2061
$ git checkout pull/2061

Update a local copy of the PR:
$ git checkout pull/2061
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2061/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2061

View PR using the GUI difftool:
$ git pr show -t 2061

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2061.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2023

👋 Welcome back Korov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

⚠️ @Korov a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 514c0eb8363490f0941fb8c3c3dff312d125c14b
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 27, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 27, 2023

Webrevs

@phohensee
Copy link
Member

phohensee commented Jul 27, 2023

Please add the reproducer as a jtreg test, and enable pre-submit testing.

@Korov
Copy link
Author

Korov commented Jul 29, 2023

⚠️ @Korov a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 514c0eb8363490f0941fb8c3c3dff312d125c14b
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

new PR #2062

@Korov Korov closed this Jul 29, 2023
@Korov
Copy link
Author

Korov commented Jul 29, 2023

Please add the reproducer as a jtreg test, and enable pre-submit testing.

The repair logic is copied back from the higher version, and the corresponding test code is also copied back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants