8214245: Case insensitive matching doesn't work correctly for some character classes

[Korov]

fix JDK-8305733

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8214245 needs maintainer approval
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)
• Change requires CSR request JDK-8328951 to be approved

Issues

• JDK-8214245: Case insensitive matching doesn't work correctly for some character classes (Bug - P4)
• JDK-8328951: Case insensitive matching doesn't work correctly for some character classes (CSR)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2062/head:pull/2062
$ git checkout pull/2062

Update a local copy of the PR:
$ git checkout pull/2062
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2062/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2062

View PR using the GUI difftool:
$ git pr show -t 2062

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2062.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Korov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 07: Full - Incremental (f7efe2af)
• 06: Full - Incremental (250e9439)
• 05: Full - Incremental (b173e148)
• 04: Full - Incremental (fc72b89f)
• 03: Full - Incremental (83b600df)
• 02: Full - Incremental (61084547)
• 01: Full - Incremental (c5f32074)
• 00: Full (a9645f6b)

[openjdk]

@Korov This change is no longer ready for integration - check the PR body for details.

[Korov]

/integrate

[openjdk]

@Korov
Your change (at version f7efe2a) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

This repository requires approval before integration. See https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix step 6.

[phohensee]

@Korov, what testing have you done, and what do you estimate the risk is?

[Korov]

@Korov, what testing have you done, and what do you estimate the risk is?

Here we test whether the matching of Posix character, Unicode character, Unicode categories, aliases, properties, and java methods is correct under the condition of ignoring case.

Currently considered no risk.

[phohensee]

@Korov, please post a fix request comment for the JBS issue outlining risk and testing.

[phohensee]

Tagged the JBS issue.

[RealCLanger]

I don't get this. What is the difference of this change to a full backport of JDK-8214245? If there's no difference, this should be a backport of JDK-8214245. And then we'd also need to file a CSR.

[Korov]

@RealCLanger There's no difference, But I have no permission to login JBS, and I cannot create a CSR from https://bugreport.java.com/bugreport/, Can anyone give me some help on how to create a CSR? Or should I close this PR?

[Korov]

After learning about CSR, does it mean that this change may cause changes in the behavior of some programs, causing compatibility issues?

[RealCLanger]

@RealCLanger Thank you very much for your help, I have changed the title.

Looks like the bots don't recognize the short hash. You need to rename it "Backport 1d4a4fed437184b2f9fef605de40aab82846c717" (which is what I wanted to say but GitHub made the short hash out of it). And also remove the "8305733:" from the title.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[GoeLin]

/reviewers 2

Asking for a second review because intergrate was already triggered, but the CSR is still missing.

[openjdk]

@GoeLin
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[bridgekeeper]

@Korov This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[RealCLanger]

@Korov Sorry for being inactive on this one for so long. Are you still willing to follow up on this backport? In that case I would create the CSR now. Please let me know.

[Korov]

@RealCLanger Yes

[bridgekeeper]

@Korov This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@Korov This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[Korov]

/open

[openjdk]

@Korov This pull request is now open

[Korov]

Hello @RealCLanger , I'm very interested in continuing to work on this backport, Please help me create a CSR and tell me the relevant links. Thank you very much for your help.

[RealCLanger]

Hello @RealCLanger , I'm very interested in continuing to work on this backport, Please help me create a CSR and tell me the relevant links. Thank you very much for your help.

OK, I now created a CSR for 11-pool: JDK-8328951. The CSR will need a review from some OpenJDK reviewer, e.g. @phohensee or @GoeLin, would you mind taking a look?

After CSR review, we have to wait whether it'll be approved before we can continue with this backport.

[Korov]

Hello @RealCLanger , I'm very interested in continuing to work on this backport, Please help me create a CSR and tell me the relevant links. Thank you very much for your help.

OK, I now created a CSR for 11-pool: JDK-8328951. The CSR will need a review from some OpenJDK reviewer, e.g. @phohensee or @GoeLin, would you mind taking a look?

After CSR review, we have to wait whether it'll be approved before we can continue with this backport.

Thats great, thanks for your help. I will continue to pay attention to the progress of CSR.

[RealCLanger]

@Korov The CSR request got rejected, please see the comment. I agree that this change bears a compatibility risk that is maybe too high for a backport.

What's the reason that you need this in JDK11? E.g. would it be possible for you to move on to JDK17?

[Korov]

@Korov The CSR request got rejected, please see the comment. I agree that this change bears a compatibility risk that is maybe too high for a backport.

What's the reason that you need this in JDK11? E.g. would it be possible for you to move on to JDK17?

This has been fixed in JDK17, so I think this PR can be closed.