Skip to content

8307133: Open source some JTable jtreg tests #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Aug 4, 2023

I backport this for parity with 11.0.21-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307133: Open source some JTable jtreg tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2065/head:pull/2065
$ git checkout pull/2065

Update a local copy of the PR:
$ git checkout pull/2065
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2065/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2065

View PR using the GUI difftool:
$ git pr show -t 2065

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2065.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5ca0b08a7505d5c210d906e76c2a4cfc3eed64aa 8307133: Open source some JTable jtreg tests Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307133: Open source some JTable jtreg tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 6faea22: 8313878: Exclude two compiler/rtm/locking tests on ppc64le
  • d24c7df: 8313803: [11u] Exclude jdk/jfr/event/sampling/TestStackFrameLineNumbers.java
  • 06772f1: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4
  • daeb362: 8181383: com/sun/jdi/OptionTest.java fails intermittently with bind failed: Address already in use
  • 9d15f3e: 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace
  • f5f17ec: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken
  • 2c54727: 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 4, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2023

Webrevs

@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 14, 2023
@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@luchenlin
Your change (at version 94be0a5) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 15, 2023

Going to push as commit ba86e9d.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 026e328: 8306954: Open source five Focus related tests
  • 2411c88: 8238157: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java test failures because of revocation date
  • 00f3931: 8239333: Mark test AmazonCA.java with intermittent key
  • 6faea22: 8313878: Exclude two compiler/rtm/locking tests on ppc64le
  • d24c7df: 8313803: [11u] Exclude jdk/jfr/event/sampling/TestStackFrameLineNumbers.java
  • 06772f1: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4
  • daeb362: 8181383: com/sun/jdi/OptionTest.java fails intermittently with bind failed: Address already in use
  • 9d15f3e: 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace
  • f5f17ec: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken
  • 2c54727: 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 15, 2023
@openjdk openjdk bot closed this Aug 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 15, 2023
@openjdk
Copy link

openjdk bot commented Aug 15, 2023

@TheRealMDoerr @luchenlin Pushed as commit ba86e9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants