Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8213694: Test Timeout.java should run in othervm mode #207

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 9, 2021

Clean backport, matches 11.0.13-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8213694: Test Timeout.java should run in othervm mode

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/207/head:pull/207
$ git checkout pull/207

Update a local copy of the PR:
$ git checkout pull/207
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/207/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 207

View PR using the GUI difftool:
$ git pr show -t 207

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/207.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1b20a6781f3132ee1f23c795ed24dbf5e2d59b79 8213694: Test Timeout.java should run in othervm mode Aug 9, 2021
@openjdk
Copy link

openjdk bot commented Aug 9, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8213694: Test Timeout.java should run in othervm mode

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2021

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 13, 2021

Going to push as commit 94b633a.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 9fec49c: 8252194: Add automated test for fix done in JDK-8218469
  • d2d4db5: 8251252: Add automated testcase for fix done in JDK-8214253
  • 7109ca2: 8252825: Add automated test for fix done in JDK-8218479
  • 1a7a9d8: 8251254: Add automated test for fix done in JDK-8218472
  • 0459ea5: 8251166: Add automated testcases for changes done in JDK-8214112
  • b117ecc: 8214195: Align stdout messages in test/jdk/java/math/BigInteger/PrimitiveConversionTests.java
  • bdfc60a: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 13, 2021
@openjdk
Copy link

openjdk bot commented Aug 13, 2021

@shipilev Pushed as commit 94b633a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8213694 branch August 13, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant