Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239333: Mark test AmazonCA.java with intermittent key #2075

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 14, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8239333: Mark test AmazonCA.java with intermittent key (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2075/head:pull/2075
$ git checkout pull/2075

Update a local copy of the PR:
$ git checkout pull/2075
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2075/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2075

View PR using the GUI difftool:
$ git pr show -t 2075

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2075.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 14, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7f3bbc3f2075dd04ab0f54d282b8d9d02c472785 8239333: Mark test AmazonCA.java with intermittent key Aug 14, 2023
@openjdk
Copy link

openjdk bot commented Aug 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8239333: Mark test AmazonCA.java with intermittent key

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 14, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 14, 2023

Webrevs

@MBaesken
Copy link
Member Author

GHA tests have various unrelated toolchain issues, unrelated.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

Going to push as commit 00f3931.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 14, 2023
@openjdk openjdk bot closed this Aug 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 14, 2023
@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@MBaesken Pushed as commit 00f3931.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant