Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer #2079

Closed
wants to merge 1 commit into from

Conversation

benty-amzn
Copy link
Contributor

@benty-amzn benty-amzn commented Aug 15, 2023

Backport 8313796 to resolve a hotspot crash. Passes jtreg tier 1-4 tests.

This change required the following modifications:

  • Remove riscv code, as the riscv port is not present in jdk 11
  • Replace nullptr with NULL to accommodate older C++ standards/compilers

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2079/head:pull/2079
$ git checkout pull/2079

Update a local copy of the PR:
$ git checkout pull/2079
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2079/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2079

View PR using the GUI difftool:
$ git pr show -t 2079

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2079.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2023

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0e2c72d7a5206b7173af5bf69e21d21ea276bd94 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Aug 15, 2023
@openjdk
Copy link

openjdk bot commented Aug 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 15, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Aug 15, 2023

@benty-amzn This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cb392e6: 8301269: Update Commons BCEL to Version 6.7.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 15, 2023
@phohensee
Copy link
Member

Please configure pre-submit testing on your repo and run it.

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@benty-amzn Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@benty-amzn
Copy link
Contributor Author

Linux failures look like an infra issue - e.g. here.

Other platforms are clean, and I've tested linux locally.

@benty-amzn
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 18, 2023
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@benty-amzn
Your change (at version ae012a4) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

Going to push as commit 3c9dc44.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ee128b2: 8284772: GHA: Use GCC Major Version Dependencies Only
  • cb392e6: 8301269: Update Commons BCEL to Version 6.7.0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2023
@openjdk openjdk bot closed this Aug 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 18, 2023
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@phohensee @benty-amzn Pushed as commit 3c9dc44.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants