Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251361: Potential race between Logger configuration and GCs in HttpURLConWithProxy test #208

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Aug 9, 2021

This backport is simple, but it does not apply cleanly to 11u due to context conflict with "8227539: Replace wildcard address with loopback or local host in tests - part 20". It brought throws Exception to main method. I resolved that conflict by hand.

Additional testing:

  • Affected test still passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8251361: Potential race between Logger configuration and GCs in HttpURLConWithProxy test

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/208/head:pull/208
$ git checkout pull/208

Update a local copy of the PR:
$ git checkout pull/208
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 208

View PR using the GUI difftool:
$ git pr show -t 208

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/208.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 9, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport ed5696dd2ce318b2480c96b5eeaf319853ce5d89 8251361: Potential race between Logger configuration and GCs in HttpURLConWithProxy test Aug 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

This backport pull request has now been updated with issue and summary from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251361: Potential race between Logger configuration and GCs in HttpURLConWithProxy test

Keep a static reference to the logger to prevent its inadvertent garbage collection while the test is running.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 9, 2021

Mhm. Bots still consider this a clean backport. Very well.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 9, 2021

Webrevs

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 13, 2021

Got the push approval.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 13, 2021

Going to push as commit d8e1e62.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 94b633a: 8213694: Test Timeout.java should run in othervm mode
  • 9fec49c: 8252194: Add automated test for fix done in JDK-8218469
  • d2d4db5: 8251252: Add automated testcase for fix done in JDK-8214253
  • 7109ca2: 8252825: Add automated test for fix done in JDK-8218479
  • 1a7a9d8: 8251254: Add automated test for fix done in JDK-8218472
  • 0459ea5: 8251166: Add automated testcases for changes done in JDK-8214112
  • b117ecc: 8214195: Align stdout messages in test/jdk/java/math/BigInteger/PrimitiveConversionTests.java
  • bdfc60a: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 13, 2021

@shipilev Pushed as commit d8e1e62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant