Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301269: Update Commons BCEL to Version 6.7.0 #2082

Closed
wants to merge 1 commit into from

Conversation

RealLucy
Copy link
Contributor

@RealLucy RealLucy commented Aug 16, 2023

Fix request [11u]

One of the required updates of external libs.

I based the bckport to 11u on Goetz's backport to 17u, Low risk.
Except for two copyright format issues (missing comma), I had to resolve just this one file: src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/Utility.java
This file had undergone major restructuring. In the end, the resolve process resulted in a simple copy from 17 to 11.

SAP nightly testing successful. No findings attributable to this backport.
Review received.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301269: Update Commons BCEL to Version 6.7.0 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2082/head:pull/2082
$ git checkout pull/2082

Update a local copy of the PR:
$ git checkout pull/2082
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2082/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2082

View PR using the GUI difftool:
$ git pr show -t 2082

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2082.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2023

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6a44120a16d0f06b4ed9f0ebf6b0919da7070287 8301269: Update Commons BCEL to Version 6.7.0 Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 16, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 16, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the diffs exist because openjdk/jdk17u-dev@d799563 was not backported before this one. (JDK-8256919 is actually also fixed with this PR.) LGTM.

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@RealLucy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301269: Update Commons BCEL to Version 6.7.0

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • de64492: 8306133: Open source few AWT Drag & Drop related tests
  • e9ac2bc: 8271838: AmazonCA.java interop test fails
  • 9eadce3: 8306955: Open source several JComboBox jtreg tests
  • ba86e9d: 8307133: Open source some JTable jtreg tests
  • 026e328: 8306954: Open source five Focus related tests
  • 2411c88: 8238157: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java test failures because of revocation date
  • 00f3931: 8239333: Mark test AmazonCA.java with intermittent key

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 16, 2023
@RealLucy
Copy link
Contributor Author

Thank you for the review, @TheRealMDoerr
I'll go ahead and request integrate authorization.

@RealLucy
Copy link
Contributor Author

Failing pre-submit tests point to an infrastructure issue. Not related to this PR.

@RealLucy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

Going to push as commit cb392e6.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 95a42a8: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • de64492: 8306133: Open source few AWT Drag & Drop related tests
  • e9ac2bc: 8271838: AmazonCA.java interop test fails
  • 9eadce3: 8306955: Open source several JComboBox jtreg tests
  • ba86e9d: 8307133: Open source some JTable jtreg tests
  • 026e328: 8306954: Open source five Focus related tests
  • 2411c88: 8238157: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java test failures because of revocation date
  • 00f3931: 8239333: Mark test AmazonCA.java with intermittent key

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2023
@openjdk openjdk bot closed this Aug 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2023
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@RealLucy Pushed as commit cb392e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants