Skip to content

Conversation

@luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Aug 17, 2023

I backport this for parity with 11.0.21-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306718: Optimize and opensource some old AWT tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2085/head:pull/2085
$ git checkout pull/2085

Update a local copy of the PR:
$ git checkout pull/2085
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2085

View PR using the GUI difftool:
$ git pr show -t 2085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2085.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9beae21864d18054ca3762ec989d51ff0660db84 8306718: Optimize and opensource some old AWT tests Aug 17, 2023
@openjdk
Copy link

openjdk bot commented Aug 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 17, 2023
@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8306718: Optimize and opensource some old AWT tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 17, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2023

Webrevs

@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 22, 2023
@openjdk
Copy link

openjdk bot commented Aug 22, 2023

@luchenlin
Your change (at version 348dc97) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

Going to push as commit e65fbde.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 094cd26: 8307078: Opensource and clean up five more AWT Focus related tests
  • cde3cd2: 8314950: CMS may miss NMT tag after mark stack expansion
  • d0f6931: 8311033: [macos] PrinterJob does not take into account Sides attribute
  • 399633c: 8313765: Invalid CEN header (invalid zip64 extra data field size)
  • a7dab96: 8302161: Upgrade jQuery UI to version 1.13.2
  • 3c9dc44: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer
  • ee128b2: 8284772: GHA: Use GCC Major Version Dependencies Only
  • cb392e6: 8301269: Update Commons BCEL to Version 6.7.0
  • 95a42a8: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • de64492: 8306133: Open source few AWT Drag & Drop related tests
  • ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/6faea22b528a459294d2c2ae425275dfba824396...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 24, 2023
@openjdk openjdk bot closed this Aug 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@TheRealMDoerr @luchenlin Pushed as commit e65fbde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants