-
Notifications
You must be signed in to change notification settings - Fork 238
8306575: Clean up and open source four Dialog related tests #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
/integrate |
@luchenlin This pull request has not yet been marked as ready for integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks good. Did you test it manually?
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 49 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
yes, manually test pass. |
/integrate |
@luchenlin |
GHA Pre-submit test failures are unrelated. |
Going to push as commit 3dd8761.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr @luchenlin Pushed as commit 3dd8761. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I backport this for parity with 11.0.21-oracle.
test/jdk/java/awt/Dialog/DialogLocationTest.java
"random.nextInt(insetX, width - 300)" is modified as random.nextInt(int origin, int bound) is not supported in jdk11.
"System.out.println(message.formatted(newX, newY, eventLoc.x, eventLoc.y, eventLoc.x - newX, eventLoc.y - newY))"
is also modified as String.formatted(Object... args) is not supported in jdk11.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2088/head:pull/2088
$ git checkout pull/2088
Update a local copy of the PR:
$ git checkout pull/2088
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2088/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2088
View PR using the GUI difftool:
$ git pr show -t 2088
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2088.diff
Webrev
Link to Webrev Comment