Skip to content

8306575: Clean up and open source four Dialog related tests #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Aug 18, 2023

I backport this for parity with 11.0.21-oracle.

test/jdk/java/awt/Dialog/DialogLocationTest.java
"random.nextInt(insetX, width - 300)" is modified as random.nextInt(int origin, int bound) is not supported in jdk11.

"System.out.println(message.formatted(newX, newY, eventLoc.x, eventLoc.y, eventLoc.x - newX, eventLoc.y - newY))"
is also modified as String.formatted(Object... args) is not supported in jdk11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306575: Clean up and open source four Dialog related tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2088/head:pull/2088
$ git checkout pull/2088

Update a local copy of the PR:
$ git checkout pull/2088
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2088/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2088

View PR using the GUI difftool:
$ git pr show -t 2088

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2088.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8d696aea9e1cefca97a760c017a5fde545facaa9 8306575: Clean up and open source four Dialog related tests Aug 18, 2023
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 18, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2023

Webrevs

@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@luchenlin This pull request has not yet been marked as ready for integration.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good. Did you test it manually?

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8306575: Clean up and open source four Dialog related tests

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • bcce7af: 8306372: Open source AWT CardLayout and Checkbox tests
  • 423e969: Merge
  • d4e7c76: 8314960: Add Certigna Root CA - 2
  • 14fa970: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
  • 50074a0: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
  • 765f6af: 8313626: C2 crash due to unexpected exception control flow
  • 3eb7a82: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • 5327f67: 8313707: GHA: Bootstrap sysroots with --variant=minbase
  • 72018a1: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0
  • dc47d1f: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures
  • ... and 39 more: https://git.openjdk.org/jdk11u-dev/compare/6faea22b528a459294d2c2ae425275dfba824396...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2023
@luchenlin
Copy link
Contributor Author

Backport looks good. Did you test it manually?

yes, manually test pass.

@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 8, 2023
@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@luchenlin
Your change (at version 2a97ebb) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

GHA Pre-submit test failures are unrelated.
/sponsor

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

Going to push as commit 3dd8761.
Since your change was applied there have been 53 commits pushed to the master branch:

  • 470789a: 8311813: C1: Uninitialized PhiResolver::_loop field
  • 0d9a364: 8306135: Clean up and open source some AWT tests
  • 0713dbb: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
  • 0fd1ce3: 8233847: (sctp) Flx link-local IPv6 scope handling and test cleanup.
  • bcce7af: 8306372: Open source AWT CardLayout and Checkbox tests
  • 423e969: Merge
  • d4e7c76: 8314960: Add Certigna Root CA - 2
  • 14fa970: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
  • 50074a0: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
  • 765f6af: 8313626: C2 crash due to unexpected exception control flow
  • ... and 43 more: https://git.openjdk.org/jdk11u-dev/compare/6faea22b528a459294d2c2ae425275dfba824396...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2023
@openjdk openjdk bot closed this Sep 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@TheRealMDoerr @luchenlin Pushed as commit 3dd8761.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants