-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293107: GHA: Bump to Ubuntu 22.04 #2090
Conversation
…host and cross builds
…ke and configure arguments
…pdates Reviewed-by: clanger, mbaesken, stuefe
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
/issue add 8293098,8293361,8293107,8295213,8295885,8313428 |
@shipilev Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: |
This backport pull request has now been updated with issue from the original commit. |
What is the reason for this PR, reducing maintenance by reducing delta to upstream? I would slightly prefer testing 11u on older systems with older glibcs (20.04 still rocks 2.31, which predates mallinfo2() for instance). |
Webrevs
|
We had the longer discussion about this already in the RFE itself.
Yes. This is how you look at it: GHA is not under our control. When GHA infra changes, it changes globally for all JDK releases currently in testing. Therefore, the sane way to maintain GHA across JDK release repos is to keep it in sync as much as possible. That's what we did in 17u, and this is what we have to do in 11u, lest somebody is signing up to maintain the diverged 11u GHA going forward.
We cannot do toolchain compatibility testing with GHA, because GHA infra is not under our control. If we keep old GHA code, the testing would first slow down, then it would start sporadically break on the way to EOL, and then it would completely break. Which also means we would be forced to do this sync anyway. |
Will this change causes the same breakages we had when the minor version of gcc was changed? I prefer to ignore that minor number in GA. |
In current form, yes, that's a risk that is shared with mainline, 21u, 17u, and until recently 11u GHAs. It would still be there until we backport the GHA change that drops the minor GCC version from all GHAs. |
Actually, we should just reapply JDK-8284772 on top, so minor versions get eliminated again. I just approved JDK-8284772 for inclusion in mainline, which should eliminate the 11u vs mainline difference again. |
I think we should proceed with this. Can I have some formal reviews? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the effort. Please add approval labels.
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks! I think I marked all mentioned issues now. |
Got the push approval for all issues now. Integrating to make GHA more reliable. /integrate |
Going to push as commit b984b0a.
Your commit was automatically rebased without conflicts. |
This similar to the bulk GHA update we did here: shipilev/jdk17u-dev@260f287 -- but now for 11u.
Note this reverts and then reapplies JDK-8284772 to avoid backport conflicts.
There are other GHA improvements we would backport later. This one atomic PR brings in 11u GHA closer to mainline GHA state without breaking the builds. For reference, after this PR, the 11u-vs-mainline GHA diff would be this: gha-11u-vs-mainline.patch
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2090/head:pull/2090
$ git checkout pull/2090
Update a local copy of the PR:
$ git checkout pull/2090
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2090/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2090
View PR using the GUI difftool:
$ git pr show -t 2090
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2090.diff
Webrev
Link to Webrev Comment