Skip to content

8312535: MidiSystem.getSoundbank() throws unexpected SecurityException#2095

Closed
mrserb wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:mrserb-backport-87298d2a
Closed

8312535: MidiSystem.getSoundbank() throws unexpected SecurityException#2095
mrserb wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:mrserb-backport-87298d2a

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Aug 24, 2023

Hi all,

This pull request contains a backport of commit 87298d2a from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312535: MidiSystem.getSoundbank() throws unexpected SecurityException (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2095/head:pull/2095
$ git checkout pull/2095

Update a local copy of the PR:
$ git checkout pull/2095
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2095/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2095

View PR using the GUI difftool:
$ git pr show -t 2095

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2095.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 87298d2ade41c689d3140981a123b0e9130fc651 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 24, 2023
@mrserb mrserb marked this pull request as ready for review August 24, 2023 18:15
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8312535: MidiSystem.getSoundbank() throws unexpected SecurityException

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • c86ba43: 8312972: Bump update version for OpenJDK: jdk-11.0.22
  • 39986e0: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java
  • 749ecd5: Merge
  • fffaff3: 8313765: Invalid CEN header (invalid zip64 extra data field size)
  • 1b3c516: 8314678: Bump update version for OpenJDK: jdk-11.0.20.1
  • 89a88f0: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0
  • e1b839e: 8302182: Update Public Suffix List to 88467c9
  • 81806b7: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612
  • 2bfbe31: 8295737: macOS: Print content cut off when width > height with portrait orientation
  • 2b9f562: 8217612: (CL)HSDB cannot show some JVM flags
  • ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/d0f6931ab7f9e3ad30365abfa862958820035ee3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Aug 31, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

Going to push as commit 121c997.
Since your change was applied there have been 18 commits pushed to the master branch:

  • d76e6ea: 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly
  • b77c161: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
  • b984b0a: 8293107: GHA: Bump to Ubuntu 22.04
  • c86ba43: 8312972: Bump update version for OpenJDK: jdk-11.0.22
  • 39986e0: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java
  • 749ecd5: Merge
  • fffaff3: 8313765: Invalid CEN header (invalid zip64 extra data field size)
  • 1b3c516: 8314678: Bump update version for OpenJDK: jdk-11.0.20.1
  • 89a88f0: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0
  • e1b839e: 8302182: Update Public Suffix List to 88467c9
  • ... and 8 more: https://git.openjdk.org/jdk11u-dev/compare/d0f6931ab7f9e3ad30365abfa862958820035ee3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2023
@openjdk openjdk bot closed this Aug 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@mrserb Pushed as commit 121c997.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant