-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8314950: CMS may miss NMT tag after mark stack expansion #2097
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@zhengyu123 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit cde3cd2. |
@zhengyu123 Pushed as commit cde3cd2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hold on now, you need to request |
@zhengyu123 ^^^ |
Please review this small fix that tags new mark stack after expansion.
Thanks @MBaesken for reporting this bug.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2097/head:pull/2097
$ git checkout pull/2097
Update a local copy of the PR:
$ git checkout pull/2097
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2097/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2097
View PR using the GUI difftool:
$ git pr show -t 2097
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2097.diff
Webrev
Link to Webrev Comment