Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314950: CMS may miss NMT tag after mark stack expansion #2097

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Aug 24, 2023

Please review this small fix that tags new mark stack after expansion.

Thanks @MBaesken for reporting this bug.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314950: CMS may miss NMT tag after mark stack expansion (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2097/head:pull/2097
$ git checkout pull/2097

Update a local copy of the PR:
$ git checkout pull/2097
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2097/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2097

View PR using the GUI difftool:
$ git pr show -t 2097

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2097.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2023

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 24, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2023

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8314950: CMS may miss NMT tag after mark stack expansion

Reviewed-by: shade, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 24, 2023
@zhengyu123
Copy link
Contributor Author

Thanks, @shipilev and @MBaesken

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

Going to push as commit cde3cd2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 24, 2023
@openjdk openjdk bot closed this Aug 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@zhengyu123 Pushed as commit cde3cd2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev
Copy link
Member

/integrate

Hold on now, you need to request jdk11u-fix-request for pushes to jdk11u-dev. Please do one retro-actively. If maintainers reject the backport, we would need to yank it.

@shipilev
Copy link
Member

@zhengyu123 ^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants