Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289077: Add manual tests to open #2102

Closed
wants to merge 4 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Aug 29, 2023

I backport this for parity with 11.0.22-oracle.

string """ was modified as it is not supported on jdk11.
test/jdk/java/awt/Icon/IconShowingTest/IconShowingTest.java
make setIcons non-static


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8289077 needs maintainer approval

Issue

  • JDK-8289077: Add manual tests to open (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2102/head:pull/2102
$ git checkout pull/2102

Update a local copy of the PR:
$ git checkout pull/2102
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2102

View PR using the GUI difftool:
$ git pr show -t 2102

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2102.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 29, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 787e16bb444ee3b63803f5d1701d0f0a68b5d474 8289077: Add manual tests to open Aug 29, 2023
@openjdk
Copy link

openjdk bot commented Aug 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8289077: Add manual tests to open

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 250d7a8: 8214694: cleanup rawtypes warnings in open jndi tests
  • fac5955: 8238740: java/net/httpclient/whitebox/FlowTestDriver.java should not specify a TLS protocol
  • f2488a3: 8317374: Add Let's Encrypt ISRG Root X2
  • 7814102: 8244508: JFR: FlightRecorderOptions reset date format
  • 10ddd51: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
  • 45e3cbf: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • 046b213: 8268916: Tests for AffirmTrust roots
  • 5a7b227: 8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows
  • 1b6ff86: 8260035: Deproblemlist few problemlisted test
  • 4aa3196: 8258914: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/2b9d54a02241dd9fad8a1e330eacc80079385dcc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 29, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 29, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 26, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 26, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

@luchenlin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot removed the clean label Nov 10, 2023
Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I verified the tests pass on win.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Nov 23, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@luchenlin
Your change (at version 01cfcc0) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 23, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

Going to push as commit fca62cf.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 250d7a8: 8214694: cleanup rawtypes warnings in open jndi tests
  • fac5955: 8238740: java/net/httpclient/whitebox/FlowTestDriver.java should not specify a TLS protocol
  • f2488a3: 8317374: Add Let's Encrypt ISRG Root X2
  • 7814102: 8244508: JFR: FlightRecorderOptions reset date format
  • 10ddd51: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
  • 45e3cbf: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • 046b213: 8268916: Tests for AffirmTrust roots
  • 5a7b227: 8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows
  • 1b6ff86: 8260035: Deproblemlist few problemlisted test
  • 4aa3196: 8258914: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/2b9d54a02241dd9fad8a1e330eacc80079385dcc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2023
@openjdk openjdk bot closed this Nov 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2023
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Nov 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@GoeLin @luchenlin Pushed as commit fca62cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants