New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8289077: Add manual tests to open #2102
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
|
@luchenlin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I verified the tests pass on win.
/integrate |
@luchenlin |
/sponsor |
Going to push as commit fca62cf.
Your commit was automatically rebased without conflicts. |
@GoeLin @luchenlin Pushed as commit fca62cf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I backport this for parity with 11.0.22-oracle.
string """ was modified as it is not supported on jdk11.
test/jdk/java/awt/Icon/IconShowingTest/IconShowingTest.java
make setIcons non-static
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2102/head:pull/2102
$ git checkout pull/2102
Update a local copy of the PR:
$ git checkout pull/2102
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2102/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2102
View PR using the GUI difftool:
$ git pr show -t 2102
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2102.diff
Webrev
Link to Webrev Comment