Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294281: Allow warnings to be disabled on a per-file basis #2109

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Aug 30, 2023

Hi all,

This pull request contains a backport of commit e45f3d51 from the openjdk/jdk repository.

The commit being backported was authored by Magnus Ihse Bursie on 23 Sep 2022 and was reviewed by Erik Joelsson.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294281: Allow warnings to be disabled on a per-file basis (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2109/head:pull/2109
$ git checkout pull/2109

Update a local copy of the PR:
$ git checkout pull/2109
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2109

View PR using the GUI difftool:
$ git pr show -t 2109

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2109.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e45f3d5176e4affaa08480b560ca983fdbcb2846 8294281: Allow warnings to be disabled on a per-file basis Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review August 30, 2023 19:17
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8294281: Allow warnings to be disabled on a per-file basis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Aug 31, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

Going to push as commit caa05ac.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 4cd3ad9: 8299330: Minor improvements in MSYS2 Workflow handling
  • 373be43: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one
  • f5eb11f: 8294941: GHA: Cut down cross-compilation sysroots
  • 121c997: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2023
@openjdk openjdk bot closed this Aug 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@mrserb Pushed as commit caa05ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant