Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306372: Open source AWT CardLayout and Checkbox tests #2112

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Sep 1, 2023

I backport this for parity with 11.0.21-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306372: Open source AWT CardLayout and Checkbox tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2112/head:pull/2112
$ git checkout pull/2112

Update a local copy of the PR:
$ git checkout pull/2112
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2112

View PR using the GUI difftool:
$ git pr show -t 2112

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2112.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 781d6d793ad4cecb774bcbcb362c726779408ffd 8306372: Open source AWT CardLayout and Checkbox tests Sep 1, 2023
@openjdk
Copy link

openjdk bot commented Sep 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 1, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8306372: Open source AWT CardLayout and Checkbox tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 50074a0: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
  • 765f6af: 8313626: C2 crash due to unexpected exception control flow
  • 3eb7a82: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • 5327f67: 8313707: GHA: Bootstrap sysroots with --variant=minbase
  • 72018a1: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0
  • dc47d1f: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures
  • 1bbbad1: 8315480: [11u] Harmonize GHA cross-compilation block with mainline
  • 7ce9271: 8314262: GHA: Cut down cross-compilation sysroots deeper
  • caa05ac: 8294281: Allow warnings to be disabled on a per-file basis
  • 4cd3ad9: 8299330: Minor improvements in MSYS2 Workflow handling
  • ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/89a88f054503cc12052116bde61f01947c2a2d4f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 1, 2023

Webrevs

@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@luchenlin
Your change (at version 14a46f2) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

Going to push as commit bcce7af.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 423e969: Merge
  • d4e7c76: 8314960: Add Certigna Root CA - 2
  • 14fa970: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
  • 50074a0: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
  • 765f6af: 8313626: C2 crash due to unexpected exception control flow
  • 3eb7a82: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • 5327f67: 8313707: GHA: Bootstrap sysroots with --variant=minbase
  • 72018a1: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0
  • dc47d1f: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures
  • 1bbbad1: 8315480: [11u] Harmonize GHA cross-compilation block with mainline
  • ... and 14 more: https://git.openjdk.org/jdk11u-dev/compare/89a88f054503cc12052116bde61f01947c2a2d4f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2023
@openjdk openjdk bot closed this Sep 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@TheRealMDoerr @luchenlin Pushed as commit bcce7af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants