Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Sep 1, 2023

Improves GHA stability and matches what mainline GHA is doing. Semi-clean due to contextual differences.

Additional testing:

  • GHA (cross-builds are still working)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313707: GHA: Bootstrap sysroots with --variant=minbase (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2115/head:pull/2115
$ git checkout pull/2115

Update a local copy of the PR:
$ git checkout pull/2115
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2115

View PR using the GUI difftool:
$ git pr show -t 2115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2115.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 29f1d8ef50e3b4b235177fd9642a1fcf26fe3bab 8313707: GHA: Bootstrap sysroots with --variant=minbase Sep 1, 2023
@openjdk
Copy link

openjdk bot commented Sep 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 1, 2023
@openjdk
Copy link

openjdk bot commented Sep 1, 2023

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8313707: GHA: Bootstrap sysroots with --variant=minbase

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • dc47d1f: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 1, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Sep 4, 2023

Testing is clean. Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 4, 2023

Going to push as commit 5327f67.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 72018a1: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0
  • dc47d1f: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 4, 2023
@openjdk openjdk bot closed this Sep 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2023
@openjdk
Copy link

openjdk bot commented Sep 4, 2023

@shipilev Pushed as commit 5327f67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant