Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar #2116

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Sep 2, 2023

The security fix, JDK-8300596, introduced a maximum size for signature-related files in JAR files, via the jdk.jar.maxSignatureFileSize property. The default value of 8MB has since proven to be too low for some JARs in general use. This change doubles it to 16MB, while still being much lower than the previous MAX_ARRAY_SIZE value of Integer.MAX_VALUE - 8

This pull request contains a clean backport of commit e47a84f2 from the openjdk/jdk repository.

The commit being backported was authored by Hai-May Chao on 31 Jul 2023 and was reviewed by Sean Mullan and Matthias Baesken.


Progress

  • Change requires CSR request JDK-8313216 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar (Enhancement - P3)
  • JDK-8313216: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2116/head:pull/2116
$ git checkout pull/2116

Update a local copy of the PR:
$ git checkout pull/2116
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2116

View PR using the GUI difftool:
$ git pr show -t 2116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2116.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2023

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e47a84f23dd2608c6f5748093eefe301fb5bf750 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar Sep 2, 2023
@openjdk
Copy link

openjdk bot commented Sep 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 2, 2023

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 2, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2023

Webrevs

@RealCLanger
Copy link
Contributor

RealCLanger commented Sep 4, 2023

@gnu-andrew I think we should do this in jdk11u to make it part of the October update (as it is for OpenJDK 17 and 21). If you agree, please transplant the PR to jdk11u.

@gnu-andrew
Copy link
Member Author

@gnu-andrew I think we should do this in jdk11u to make it part of the October update (as it is for OpenJDK 17 and 21). If you agree, please transplant the PR to jdk11u.

It's in the January 17 update (17.0.10) for both us and Oracle. Also, I don't think this is a critical fix. There is an easy workaround by setting the property explicitly.

@RealCLanger
Copy link
Contributor

@gnu-andrew I think we should do this in jdk11u to make it part of the October update (as it is for OpenJDK 17 and 21). If you agree, please transplant the PR to jdk11u.

It's in the January 17 update (17.0.10) for both us and Oracle. Also, I don't think this is a critical fix. There is an easy workaround by setting the property explicitly.

OK then, I just thought the symmetry to JDK17 would be nice. But as you say, it's not that critical.

@gnu-andrew
Copy link
Member Author

@gnu-andrew I think we should do this in jdk11u to make it part of the October update (as it is for OpenJDK 17 and 21). If you agree, please transplant the PR to jdk11u.

It's in the January 17 update (17.0.10) for both us and Oracle. Also, I don't think this is a critical fix. There is an easy workaround by setting the property explicitly.

OK then, I just thought the symmetry to JDK17 would be nice. But as you say, it's not that critical.

It went in after rampdown in 17 too :)
I see jdk11u-fix-yes
/integrate

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

Going to push as commit 50074a0.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 765f6af: 8313626: C2 crash due to unexpected exception control flow
  • 3eb7a82: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • 5327f67: 8313707: GHA: Bootstrap sysroots with --variant=minbase

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 5, 2023
@openjdk openjdk bot closed this Sep 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@gnu-andrew Pushed as commit 50074a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants