-
Notifications
You must be signed in to change notification settings - Fork 251
8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses #2125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back fyang! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
phohensee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean backport from 17u.
|
GHA failure is an infrastructure issue. |
|
@RealFYang This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
GHA is now clean. Push approval is granted. |
|
Going to push as commit 0713dbb. |
|
@RealFYang Pushed as commit 0713dbb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport to improve arm32 performance in 11u and riscv-port in: openjdk/riscv-port-jdk11u#3.
This is not a clean backport as the function has been moved to new file and renamed.
I checked the 11u related code and I think the following analysis on the JBS description is still true for 11u:
"The intrinsic is currently only implemented in C2. I see no reason for this intrinsic to depend on
UseUnalignedAccesses: whatLibraryCallKit::inline_unsafe_allocate()does seems similar to what the regularParse::do_new()does, namely doing the clinit barrier and then delegating intoGraphKit::new_instance."Tested with the initial riscv-port in: openjdk/riscv-port-jdk11u#3
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2125/head:pull/2125$ git checkout pull/2125Update a local copy of the PR:
$ git checkout pull/2125$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2125/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2125View PR using the GUI difftool:
$ git pr show -t 2125Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2125.diff
Webrev
Link to Webrev Comment