Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses #2125

Closed
wants to merge 2 commits into from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Sep 8, 2023

Backport to improve arm32 performance in 11u and riscv-port in: openjdk/riscv-port-jdk11u#3.
This is not a clean backport as the function has been moved to new file and renamed.

I checked the 11u related code and I think the following analysis on the JBS description is still true for 11u:
"The intrinsic is currently only implemented in C2. I see no reason for this intrinsic to depend on UseUnalignedAccesses: what LibraryCallKit::inline_unsafe_allocate() does seems similar to what the regular Parse::do_new() does, namely doing the clinit barrier and then delegating into GraphKit::new_instance."

Tested with the initial riscv-port in: openjdk/riscv-port-jdk11u#3


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2125/head:pull/2125
$ git checkout pull/2125

Update a local copy of the PR:
$ git checkout pull/2125
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2125

View PR using the GUI difftool:
$ git pr show -t 2125

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2125.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2023

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c0623972cffdbcd7f80e84a1ec344fd382a4a5cc 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses Sep 8, 2023
@openjdk
Copy link

openjdk bot commented Sep 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 8, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport from 17u.

@phohensee
Copy link
Member

GHA failure is an infrastructure issue.

@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@RealFYang This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2023
@RealFYang
Copy link
Member Author

GHA is now clean. Push approval is granted.
/integrate

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

Going to push as commit 0713dbb.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 12, 2023
@openjdk openjdk bot closed this Sep 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 12, 2023
@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@RealFYang Pushed as commit 0713dbb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants