Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java #213

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Aug 9, 2021

A clean backport to add missing test case of JDK-8225583.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/213/head:pull/213
$ git checkout pull/213

Update a local copy of the PR:
$ git checkout pull/213
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/213/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 213

View PR using the GUI difftool:
$ git pr show -t 213

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/213.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 9, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d577d9c678b9b14227731d9cf7b2328100d66428 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java Aug 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Aug 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 9, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine. Since it is now a clean backport, it only requires a push approval (jdk11u-fix-yes).

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Aug 18, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

Going to push as commit 6722cee.
Since your change was applied there have been 38 commits pushed to the master branch:

  • 5ce46d9: 8248403: AArch64: Remove uses of kernel integer types
  • 3db0637: 8272197: Update 11u GHA workflow with Shenandoah configurations
  • 55545f4: 8225082: Remove IdenTrust certificate that is expiring in September 2021
  • 12312a3: 8230841: Remove oopDesc::equals()
  • 8a470e1: 8209768: Refactor java/util/prefs/CheckUserPrefsStorage.sh to plain java test
  • 8738bb5: 8213409: Refactor sun.text.IntHashtable:i18n shell tests to plain java tests
  • 2c3f99d: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
  • 80972c5: 8214520: [TEST_BUG] sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java failed with incorrect jtreg tags order
  • ac8510b: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java
  • b9c24c3: 8210802: temp files left by tests in jdk/java/net/httpclient
  • ... and 28 more: https://git.openjdk.java.net/jdk11u-dev/compare/5f9429b58f68a2d71b3dae96e15353b780c745a3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@zhengyu123 Pushed as commit 6722cee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants