Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307079: Update test java/awt/Choice/DragOffNoSelect.java #2131

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Sep 14, 2023

I backport this for parity with 11.0.21-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307079: Update test java/awt/Choice/DragOffNoSelect.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2131/head:pull/2131
$ git checkout pull/2131

Update a local copy of the PR:
$ git checkout pull/2131
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2131

View PR using the GUI difftool:
$ git pr show -t 2131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2131.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 89711f376751d4cfa05758705867afedfafeb602 8307079: Update test java/awt/Choice/DragOffNoSelect.java Sep 14, 2023
@openjdk
Copy link

openjdk bot commented Sep 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307079: Update test java/awt/Choice/DragOffNoSelect.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 723c0c0: 8195589: T6587786.java failed after JDK-8189997
  • 6fe8172: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • de3589c: 8205467: javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java possible deadlock
  • 94c048f: 8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges
  • 22dd2d3: 8207166: jdk/jshell/JdiHangingLaunchExecutionControlTest.java - launch timeout
  • 5c7ec0d: 8315862: [11u] Backport 8227337: javax/management/remote/mandatory/connection/ReconnectTest.java NoSuchObjectException no such object in table

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2023

Webrevs

@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@luchenlin
Your change (at version f46d5fe) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Sep 22, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit 72d97e0.
Since your change was applied there have been 12 commits pushed to the master branch:

  • cd3c64f: 8306430: Open source some AWT tests related to TextComponent and Toolkit
  • ce1602d: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
  • 70862e0: 8315863: [GHA] Update checkout action to use v4
  • d003824: Merge
  • f356adb: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • d52e9ed: 8316380: [11u] Backport 8170089: nsk/jdi/EventSet/resume/resume008: ERROR: suspendCounts don't match for : Common-Cleaner
  • 723c0c0: 8195589: T6587786.java failed after JDK-8189997
  • 6fe8172: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • de3589c: 8205467: javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java possible deadlock
  • 94c048f: 8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/269224c81b259136312a1969e2f4d38f45608544...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@GoeLin @luchenlin Pushed as commit 72d97e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants