Skip to content

Conversation

@yukikimmura
Copy link
Member

@yukikimmura yukikimmura commented Sep 20, 2023

I would like to backport this fix to 11u.
The original patch applies cleanly to 11u.
There is no risk, because the logic around the changes is same as jdk17
Testing:
all serviceability area tests jdk_svc, and a specific test to verify the fix.

Could anyone review the fix please?

Thanks,
Kimura Yukihiro


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2134/head:pull/2134
$ git checkout pull/2134

Update a local copy of the PR:
$ git checkout pull/2134
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2134

View PR using the GUI difftool:
$ git pr show -t 2134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2134.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2023

👋 Welcome back kyukihiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7286bb8518543501045de4cf970094ac9c1af4fa 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@yukikimmura This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2023

Webrevs

@yukikimmura
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@yukikimmura
Your change (at version 69c60d8) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Sep 22, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit cdc33dc.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 72d97e0: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
  • cd3c64f: 8306430: Open source some AWT tests related to TextComponent and Toolkit
  • ce1602d: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
  • 70862e0: 8315863: [GHA] Update checkout action to use v4
  • d003824: Merge
  • f356adb: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • d52e9ed: 8316380: [11u] Backport 8170089: nsk/jdi/EventSet/resume/resume008: ERROR: suspendCounts don't match for : Common-Cleaner

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@GoeLin @yukikimmura Pushed as commit cdc33dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants