-
Notifications
You must be signed in to change notification settings - Fork 251
8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows #2134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows #2134
Conversation
|
👋 Welcome back kyukihiro! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@yukikimmura This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@yukikimmura |
|
/sponsor |
|
Going to push as commit cdc33dc.
Your commit was automatically rebased without conflicts. |
|
@GoeLin @yukikimmura Pushed as commit cdc33dc. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I would like to backport this fix to 11u.
The original patch applies cleanly to 11u.
There is no risk, because the logic around the changes is same as jdk17
Testing:
all serviceability area tests jdk_svc, and a specific test to verify the fix.
Could anyone review the fix please?
Thanks,
Kimura Yukihiro
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2134/head:pull/2134$ git checkout pull/2134Update a local copy of the PR:
$ git checkout pull/2134$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2134/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2134View PR using the GUI difftool:
$ git pr show -t 2134Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2134.diff
Webrev
Link to Webrev Comment