Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different #2139

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 22, 2023

I backport this for parity with 11.0.22-oracle.

I had to fix the syntac of the test, as isEmtpy() is not availabe in 11.
Replaced by errorLog != null && errorLog.length() > 0.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8288325 needs maintainer approval

Issue

  • JDK-8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2139/head:pull/2139
$ git checkout pull/2139

Update a local copy of the PR:
$ git checkout pull/2139
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2139

View PR using the GUI difftool:
$ git pr show -t 2139

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2139.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport eca9749da01d732033c07f2bbb38800a9d80f18d 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 22, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 23, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b2a6484: 8316178: Better diagnostic header for CodeBlobs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2023
@openjdk
Copy link

openjdk bot commented Sep 26, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated approval labels Sep 26, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 27, 2023

Going to push as commit 2513c89.
Since your change was applied there has been 1 commit pushed to the master branch:

  • b2a6484: 8316178: Better diagnostic header for CodeBlobs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 27, 2023
@openjdk openjdk bot closed this Sep 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@GoeLin Pushed as commit 2513c89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8288325 branch September 27, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants