Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md #2141

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Sep 22, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313792 needs maintainer approval

Issue

  • JDK-8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2141/head:pull/2141
$ git checkout pull/2141

Update a local copy of the PR:
$ git checkout pull/2141
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2141

View PR using the GUI difftool:
$ git pr show -t 2141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2141.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 87a6acbeee1673526bfc5f8692e0949cb113e841 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • c2ac5e2: 8301065: Handle control characters in java_lang_String::print
  • bcac47f: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • e7b2077: 8316206: Test StretchedFontTest.java fails for Baekmuk font
  • 2513c89: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different
  • b2a6484: 8316178: Better diagnostic header for CodeBlobs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 26, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval and removed ready Pull request is ready to be integrated labels Sep 26, 2023
@GoeLin
Copy link
Member

GoeLin commented Sep 28, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@GoeLin
8313792: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 28, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@luchenlin
Your change (at version f6e6eb4) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Sep 28, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

Going to push as commit f530f34.
Since your change was applied there have been 5 commits pushed to the master branch:

  • c2ac5e2: 8301065: Handle control characters in java_lang_String::print
  • bcac47f: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • e7b2077: 8316206: Test StretchedFontTest.java fails for Baekmuk font
  • 2513c89: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different
  • b2a6484: 8316178: Better diagnostic header for CodeBlobs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 28, 2023
@openjdk openjdk bot closed this Sep 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@GoeLin @luchenlin Pushed as commit f530f34.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants