8267860: Off-by-one bug when searching arrays in AlpnGreaseTest

[amosshi]

• This is the back port of JDK-8267860 : Off-by-one bug when searching arrays in AlpnGreaseTest
• The original commit is openjdk/jdk@2adef6a
• The test case has been verified working in local

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8267860 needs maintainer approval

Issue

• JDK-8267860: Off-by-one bug when searching arrays in AlpnGreaseTest (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2144/head:pull/2144
$ git checkout pull/2144

Update a local copy of the PR:
$ git checkout pull/2144
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2144/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2144

View PR using the GUI difftool:
$ git pr show -t 2144

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2144.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @amosshi, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user amosshi" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[GoeLin]

/covered Amos Shi is an SAP colleague now working on the 11u and 17u updates projects. He is covered by the SAP OCA.

[mlbridge]

Webrevs

• 00: Full (155b11b5)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[amosshi]

/approval

[openjdk]

@amosshi usage: /approval [<id>] (request|cancel) [<text>]

[openjdk]

@amosshi The approval request has been created successfully.

[amosshi]

/approval request Backport

[openjdk]

@amosshi The approval request has been updated successfully.

[GoeLin]

/approve yes

[openjdk]

@GoeLin
8267860: The approval request has been approved.

[openjdk]

⚠️ @amosshi the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8267860
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267860: Off-by-one bug when searching arrays in AlpnGreaseTest

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 0beae37: 8280004: DCmdArgument::parse_value() should handle NULL input
• 166adaa: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
• ffef098: 8290067: Show stack dimensions in UL logging when attaching threads
• f530f34: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md
• c2ac5e2: 8301065: Handle control characters in java_lang_String::print
• bcac47f: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
• e7b2077: 8316206: Test StretchedFontTest.java fails for Baekmuk font
• 2513c89: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[amosshi]

/integrate

[openjdk]

@amosshi
Your change (at version 155b11b) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit cf722df.
Since your change was applied there have been 8 commits pushed to the master branch:

• 0beae37: 8280004: DCmdArgument::parse_value() should handle NULL input
• 166adaa: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
• ffef098: 8290067: Show stack dimensions in UL logging when attaching threads
• f530f34: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md
• c2ac5e2: 8301065: Handle control characters in java_lang_String::print
• bcac47f: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
• e7b2077: 8316206: Test StretchedFontTest.java fails for Baekmuk font
• 2513c89: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @amosshi Pushed as commit cf722df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.