Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316514: Better diagnostic header for VtableStub #2146

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 25, 2023

Semi-clean backport to improve JVM diagnostics. The context in 11u is a bit different, but otherwise the patch is the same.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316514 needs maintainer approval

Issue

  • JDK-8316514: Better diagnostic header for VtableStub (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2146/head:pull/2146
$ git checkout pull/2146

Update a local copy of the PR:
$ git checkout pull/2146
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2146

View PR using the GUI difftool:
$ git pr show -t 2146

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2146.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@shipilev shipilev changed the title Bacport 6c61bc195090abf73683b811e214810a1226d299 Backport 6c61bc195090abf73683b811e214810a1226d299 Sep 25, 2023
@openjdk openjdk bot changed the title Backport 6c61bc195090abf73683b811e214810a1226d299 8316514: Better diagnostic header for VtableStub Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 25, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2023

Webrevs

@shipilev
Copy link
Member Author

/clean

@openjdk openjdk bot added the clean label Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@shipilev This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316514: Better diagnostic header for VtableStub

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 059f73c: 8242330: Arrays should be cloned in several JAAS Callback classes
  • 96e3db7: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
  • fb7e6e3: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
  • ac0bc1b: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 51a80dd: 8293466: libjsig should ignore non-modifying sigaction calls
  • a4b3027: 8271519: java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java failed with "Total [200] - Expected [400]"
  • cf722df: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest
  • 0beae37: 8280004: DCmdArgument::parse_value() should handle NULL input
  • 166adaa: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
  • ffef098: 8290067: Show stack dimensions in UL logging when attaching threads
  • ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/70862e011ba642a782cf28004d2f9dd807971788...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 26, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval and removed ready Pull request is ready to be integrated labels Sep 26, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 5, 2023

Pre-submit failure: timeouts in jshell tests. Pretty sure unrelated.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 5, 2023
@shipilev
Copy link
Member Author

shipilev commented Oct 5, 2023

Yes, I think those failures are unrelated. Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

Going to push as commit 682bcf2.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 059f73c: 8242330: Arrays should be cloned in several JAAS Callback classes
  • 96e3db7: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
  • fb7e6e3: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
  • ac0bc1b: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 51a80dd: 8293466: libjsig should ignore non-modifying sigaction calls
  • a4b3027: 8271519: java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java failed with "Total [200] - Expected [400]"
  • cf722df: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest
  • 0beae37: 8280004: DCmdArgument::parse_value() should handle NULL input
  • 166adaa: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
  • ffef098: 8290067: Show stack dimensions in UL logging when attaching threads
  • ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/70862e011ba642a782cf28004d2f9dd807971788...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2023
@openjdk openjdk bot closed this Oct 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@shipilev Pushed as commit 682bcf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants