Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316206: Test StretchedFontTest.java fails for Baekmuk font #2147

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 26, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • JDK-8316206 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316206: Test StretchedFontTest.java fails for Baekmuk font (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2147/head:pull/2147
$ git checkout pull/2147

Update a local copy of the PR:
$ git checkout pull/2147
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2147

View PR using the GUI difftool:
$ git pr show -t 2147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2147.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 00f585bd22f527eca0107a9b4ed366f25754f0be 8316206: Test StretchedFontTest.java fails for Baekmuk font Sep 26, 2023
@openjdk
Copy link

openjdk bot commented Sep 26, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 26, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316206: Test StretchedFontTest.java fails for Baekmuk font

Ignore broken fonts, i.e. the fonts for which
GlyphVector(TEXT).getVisualBounds().isEmpty() returns true

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 26, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 26, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 26, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated approval labels Sep 26, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 27, 2023

/integtrate

@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@GoeLin Unknown command integtrate - for a list of valid commands use /help.

@GoeLin
Copy link
Member Author

GoeLin commented Sep 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 27, 2023

Going to push as commit e7b2077.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 2513c89: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 27, 2023
@openjdk openjdk bot closed this Sep 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@GoeLin Pushed as commit e7b2077.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant