Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies #2150

Closed

Conversation

roy-soumadipta
Copy link
Contributor

@roy-soumadipta roy-soumadipta commented Sep 27, 2023

Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315770 merged as part of openjdk/jdk#15631. https://github.com/openjdk/jdk/commit/877731d2a20249ce4724a071ba2da1faa56daca4.patch apply failed due to differences in the file and the changes have been performed selectively.

Below are the test results:

  • after_release: 123.62s user 10.26s system 160% cpu 1:23.59 total
  • after_fastdebug: 197.42s user 15.07s system 195% cpu 1:48.49 total
  • before_release: 123.65s user 9.56s system 159% cpu 1:23.38 total
  • before_fastdebug: 232.70s user 15.29s system 170% cpu 2:25.70 total

Progress

  • JDK-8315770 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2150/head:pull/2150
$ git checkout pull/2150

Update a local copy of the PR:
$ git checkout pull/2150
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2150

View PR using the GUI difftool:
$ git pr show -t 2150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2150.diff

Webrev

Link to Webrev Comment

Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315770 merged as part of openjdk/jdk#15631. https://github.com/openjdk/jdk/commit/877731d2a20249ce4724a071ba2da1faa56daca4.patch apply failed due to differences in the file and the changes have been performed selectively.

Below are the test results:
* after_release: **123.62s user 10.26s system 160% cpu 1:23.59 total**
* after_fastdebug: **197.42s user 15.07s system 195% cpu 1:48.49 total**
* before_release: **123.65s user 9.56s system 159% cpu 1:23.38 total**
* before_fastdebug: **232.70s user 15.29s system 170% cpu 2:25.70 total**
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2023

👋 Welcome back roy-soumadipta! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 877731d2a20249ce4724a071ba2da1faa56daca4 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 27, 2023

⚠️ @roy-soumadipta This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2023

Webrevs

@roy-soumadipta
Copy link
Contributor Author

roy-soumadipta commented Sep 27, 2023

/approval request Improves test performance. Applies cleanly, test still passes.

@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@roy-soumadipta The approval request has been created successfully.

@GoeLin
Copy link
Member

GoeLin commented Sep 28, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@GoeLin
8315770: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@roy-soumadipta This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 28, 2023
@roy-soumadipta
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@roy-soumadipta
Your change (at version 5789c99) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

Going to push as commit 166adaa.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ffef098: 8290067: Show stack dimensions in UL logging when attaching threads
  • f530f34: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 28, 2023
@openjdk openjdk bot closed this Sep 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@shipilev @roy-soumadipta Pushed as commit 166adaa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@roy-soumadipta roy-soumadipta deleted the TestJmapCoreMetaSpace branch November 23, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants