Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test #2155

Conversation

roy-soumadipta
Copy link
Contributor

@roy-soumadipta roy-soumadipta commented Sep 28, 2023

Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315766 merged as part of openjdk/jdk#15710. https://github.com/openjdk/jdk/commit/edd454b502b9bacde55492820e52655bbac63b89.patch could be cleanly applied.

Below are the test results:

  • before_release: 1535.51s user 72.40s system 257% cpu 10:24.79 total
  • after_release: 1655.73s user 74.16s system 1195% cpu 2:24.68 total
  • before_fastdebug: 1064.03s user 57.21s system 177% cpu 10:32.29 total
  • after_fastdebug: 1137.89s user 58.07s system 783% cpu 2:32.61 total

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315766 needs maintainer approval

Issue

  • JDK-8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2155/head:pull/2155
$ git checkout pull/2155

Update a local copy of the PR:
$ git checkout pull/2155
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2155

View PR using the GUI difftool:
$ git pr show -t 2155

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2155.diff

Webrev

Link to Webrev Comment

Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315766 merged as part of openjdk/jdk#15710. https://github.com/openjdk/jdk/commit/edd454b502b9bacde55492820e52655bbac63b89.patch could be cleanly applied.

Below are the test results:
* before_release: **1535.51s user 72.40s system 257% cpu 10:24.79 total**
* after_release: **1655.73s user 74.16s system 1195% cpu 2:24.68 total**
* before_fastdebug: **1064.03s user 57.21s system 177% cpu 10:32.29 total**
* after_fastdebug: **1137.89s user 58.07s system 783% cpu 2:32.61 total**
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2023

👋 Welcome back roy-soumadipta! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport edd454b502b9bacde55492820e52655bbac63b89 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

⚠️ @roy-soumadipta This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 28, 2023
@roy-soumadipta
Copy link
Contributor Author

/approval request Improves test performance. Applies cleanly, test still passes.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@roy-soumadipta The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 28, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@roy-soumadipta This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • ac0bc1b: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 51a80dd: 8293466: libjsig should ignore non-modifying sigaction calls
  • a4b3027: 8271519: java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java failed with "Total [200] - Expected [400]"
  • cf722df: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest
  • 0beae37: 8280004: DCmdArgument::parse_value() should handle NULL input
  • 166adaa: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
  • ffef098: 8290067: Show stack dimensions in UL logging when attaching threads
  • f530f34: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 4, 2023
@roy-soumadipta
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@roy-soumadipta
Your change (at version 3ece568) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

Going to push as commit fb7e6e3.
Since your change was applied there have been 8 commits pushed to the master branch:

  • ac0bc1b: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 51a80dd: 8293466: libjsig should ignore non-modifying sigaction calls
  • a4b3027: 8271519: java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java failed with "Total [200] - Expected [400]"
  • cf722df: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest
  • 0beae37: 8280004: DCmdArgument::parse_value() should handle NULL input
  • 166adaa: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
  • ffef098: 8290067: Show stack dimensions in UL logging when attaching threads
  • f530f34: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2023
@openjdk openjdk bot closed this Oct 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@phohensee @roy-soumadipta Pushed as commit fb7e6e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@roy-soumadipta roy-soumadipta deleted the TestStressIHOPMultiThread branch November 23, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants