Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242330: Arrays should be cloned in several JAAS Callback classes #2157

Closed
wants to merge 2 commits into from

Conversation

yan-too
Copy link

@yan-too yan-too commented Sep 29, 2023

Backport of the fix is clean for 11u in everything but copyright dates.
CSR copy is filed as JDK-8317297.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8242330 needs maintainer approval

Issues

  • JDK-8242330: Arrays should be cloned in several JAAS Callback classes (Bug - P3 - Approved)
  • JDK-8317297: Arrays should be cloned in several JAAS Callback classes (CSR) (Withdrawn)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2157/head:pull/2157
$ git checkout pull/2157

Update a local copy of the PR:
$ git checkout pull/2157
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2157

View PR using the GUI difftool:
$ git pr show -t 2157

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2157.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2023

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8cd9241448f818b5e307d408ac4395b518791096 8242330: Arrays should be cloned in several JAAS Callback classes Sep 29, 2023
@openjdk
Copy link

openjdk bot commented Sep 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Sep 29, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2023

Webrevs

@openjdk openjdk bot removed the clean label Oct 5, 2023
@yan-too
Copy link
Author

yan-too commented Oct 5, 2023

/csr unneeded

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@yan-too The CSR requirement cannot be removed as CSR issues already exist. Please withdraw JDK-8317297 and then use the command /csr unneeded again.

@yan-too
Copy link
Author

yan-too commented Oct 5, 2023

/csr unneeded

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@yan-too The CSR requirement cannot be removed as CSR issues already exist. Please withdraw JDK-8317297 and then use the command /csr unneeded again.

@yan-too
Copy link
Author

yan-too commented Oct 5, 2023

/csr unneeded

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@yan-too determined that a CSR request is not needed for this pull request.

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you removed all the CSR relevant doc changes.

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

⚠️ @yan-too This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8242330: Arrays should be cloned in several JAAS Callback classes

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 96e3db7: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
  • fb7e6e3: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
  • ac0bc1b: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 51a80dd: 8293466: libjsig should ignore non-modifying sigaction calls
  • a4b3027: 8271519: java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java failed with "Total [200] - Expected [400]"
  • cf722df: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 5, 2023
@yan-too
Copy link
Author

yan-too commented Oct 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

Going to push as commit 059f73c.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 96e3db7: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
  • fb7e6e3: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
  • ac0bc1b: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 51a80dd: 8293466: libjsig should ignore non-modifying sigaction calls
  • a4b3027: 8271519: java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java failed with "Total [200] - Expected [400]"
  • cf722df: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2023
@openjdk openjdk bot closed this Oct 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@yan-too Pushed as commit 059f73c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants